Skip to content

fix: Change quotes for rpm-ostree installation documentation #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

manoelhc
Copy link
Contributor

@manoelhc manoelhc commented Apr 1, 2025

The current documentation leads to create a .repo file with the content:

[copr:copr.fedorainfracloud.org:pgdev:ghostty]
name=Copr repo for Ghostty owned by pgdev
baseurl=https://download.copr.fedorainfracloud.org/results/pgdev/ghostty/fedora--/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/pgdev/ghostty/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1' | sudo tee /etc/yum.repos.d/_copr:copr.fedorainfracloud.org:pgdev:ghostty.repo > /dev/null

Note that the correct baseurl must be

baseurl=https://download.copr.fedorainfracloud.org/results/pgdev/ghostty/fedora-$releasever-$basearch/

The double quotes evaluate the $releasever and $basearch values which is normally empty. This variables are used and evaluated by the rpm-ostree system and must be present as a template URL.

Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 8:46am

@manoelhc manoelhc changed the title fix: Change quotes for rpm-ostree installation fix: Change quotes for rpm-ostree installation documentation Apr 1, 2025
Copy link

@Comprehensive-Wall28 Comprehensive-Wall28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change now creates the file correctly on Fedora Silverblue
image

@mitchellh mitchellh merged commit 3f99d56 into ghostty-org:main Apr 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants