-
Notifications
You must be signed in to change notification settings - Fork 54
Add radar plot type #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add radar plot type #374
Conversation
Co-authored-by: Jacky Volpes <[email protected]>
cc @nforquet |
thanks for the addition, really appreciated! Can you share the dataset so I can start the review with the same data you have used? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the this new plot type, really appreciated! As stated in the main comment, can you share the dataset used?
self.x_combo: ['all'], | ||
self.y_label: ['scatter', 'bar', 'box', 'pie', '2dhistogram', 'polar', 'ternary', 'contour', 'violin'], | ||
self.y_combo: ['scatter', 'bar', 'box', 'pie', '2dhistogram', 'polar', 'ternary', 'contour', 'violin'], | ||
self.feature_subset_defined_button: ['scatter', 'bar', 'box', 'pie', '2dhistogram','histogram', 'polar','ternary', 'contour', 'violin'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any specific reason to not include also radar plot with the feature subset? If yes, also the label_feature_subset
label should be removed
from qgis.PyQt.QtGui import QIcon | ||
from DataPlotly.core.plot_types.plot_type import PlotType | ||
import plotly.colors as pc | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing QCoreApplication import:
from qgis.PyQt.QtCore import QCoreApplication
hi @ghtmtt , here are the test data used in the screenshots: data_test.csv |
thanks! seems fantastic! Even if the documentation repository needs a total refactor, do you mind to add also the documentation following the other plot templates? https://github.com/ghtmtt/DataPlotly-docs |
This pull request adds a new plot type: radar plots.
The logic of the radar plot is a little bit different from other plot types: an entire trace is added for each feature.
New widgets have been added:
The widgets have been added to the read/write settings features.
Funded by INRAE - Reversaal