Fix Process.terminal() returning None for PTYs opened after first call - #2838
Open
SAY-5 wants to merge 3 commits into
Open
Fix Process.terminal() returning None for PTYs opened after first call#2838SAY-5 wants to merge 3 commits into
SAY-5 wants to merge 3 commits into
Conversation
Author
|
Note: the linter CI failure is pre-existing on master (failing since 2026-05-21 15:01:49 +0200) and not caused by this PR. All 28 ruff PLW0717 errors come from files not touched by this change. |
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix-terminal-stale-cache-2830
branch
from
July 27, 2026 21:29
3dcf57f to
9e3f140
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
get_terminal_map()is decorated with@functools.lru_cacheand is never invalidated. In a long-running process that first callsterminal()(orprocess_iter(['terminal'])) before any PTYs exist, the cache is built empty. All PTYs created afterwards are invisible to subsequent calls since the cached empty dict is returned and the lookup returnsNone.On a cache miss the terminal device number is genuinely absent from the cached map. Clearing the cache and rebuilding once picks up any
/dev/pts/*entries that have appeared since the initial call.