net_if_duplex_speed: handle ENOTTY from ioctl(SIOCETHTOOL) - #2985
Open
fabiancrt wants to merge 1 commit into
Open
net_if_duplex_speed: handle ENOTTY from ioctl(SIOCETHTOOL)#2985fabiancrt wants to merge 1 commit into
fabiancrt wants to merge 1 commit into
Conversation
github-actions
Bot
added
badexc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
On the setup reported in #2693,
ioctl(SIOCETHTOOL)returnsENOTTYwhile retrieving interface duplex/speed. Since
ENOTTYis not handled,it propagates as
OSErrorand makesnet_if_stats()fail entirely.Treat
ENOTTYlike the existingEOPNOTSUPP,EINVAL, andEBUSYcases, returning unknown duplex and speed 0 instead.
This follows the same handling added for
EBUSYin #2732.