This repository was archived by the owner on Oct 30, 2024. It is now read-only.
Remove Config CR and add ConfigReference to Release Component #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubasobon
changed the title
Change more thoroughly explained in "Config Version Freeze" ADR https://github.com/giantswarm/giantswarm/blob/master/content/docs/product/architecture-specs-adrs/adr/013-config-version-freeze.md
kubasobon
force-pushed
the
argoapp-migration
branch
from
eb90130 to
2c91372
Compare
Closed
4 tasks
kopiczko
reviewed
Sep 10, 2021
Comment on lines
+99
to
+104
| // +kubebuilder:default=main | ||
| // +kubebuilder:validation:Optional | ||
| // ConfigReference specifies revision of giantswarm/config to be used for | ||
| // configuration generation. Accepts major version specification (v1) or | ||
| // branch names. | ||
| ConfigReference string `json:"configReference,omitempty"` |
Contributor
There was a problem hiding this comment.
Aren't we getting rid of this v1 thing?
Contributor
Author
There was a problem hiding this comment.
Well, if you're really adamant and pass v1 it's still accepted, same for konfigure input. Just not recommended.
Contributor
There was a problem hiding this comment.
Yeah, but I thought we'd also drop floating tags action, no?
Member
|
Please also remove https://github.com/giantswarm/apiextensions/blob/master/docs/config.yaml#L223-L228 A CHANGELOG entry would be appreciated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/18502
Checklist