-
Notifications
You must be signed in to change notification settings - Fork 7
Add interactive mode to template app command #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is an interesting experiment, and since some interactive mode or wizard mode in the CLI has been discussed here and there, it's nice to actually try out an example. I wonder: what motivated you to work on this? What problem are you trying to solve? As a general notice: I think it makes sense to invest effort into an interactive mode only if we know we want to pursue this for all or most commands. When testing the implementation here, I think it would require more work to make me want to use it. Here are some things I don't like in particular:
My guess is that it would require a good deal more work to make this a nice experience, and given the limited resources we have, I wouldn't want to give this task to any of our teams currently. |
I wanted to replicate the experience of deploying an app via Happa into CLI.
I agree and will change this.
Will see how feasible is that
That's a drawback from the library I used here. Will see if there's a way to improve this.
I will add some feedback |
What does this PR do?
This PR adds an interactive mode to the
template app
command. This mode allows users to create a new app interactively by selecting a catalog and a catalog entry from a list of available options.What is the effect of this change to users?
Users can now create a new app interactively by running
kubectl gs template app --cluster-name myCluster --interactive
and following the prompts.What does it look like?
Screenshare.-.2024-06-01.12_03_16.AM.mp4
What is needed from the reviewers?
Review the code and test the new interactive mode.
Do the docs need to be updated?
Yes online doc needs to be updated at https://docs.giantswarm.io/vintage/use-the-api/kubectl-gs/template-app/
Should this change be mentioned in the release notes?
Is this a breaking change?
No, default bevahior is unchanged.