Skip to content

Track Cargo.lock (workspace builds an executable) - #11

Merged
gilesknap merged 1 commit into
mainfrom
claude/track-cargo-lock
Jun 21, 2026
Merged

Track Cargo.lock (workspace builds an executable)#11
gilesknap merged 1 commit into
mainfrom
claude/track-cargo-lock

Conversation

@gilesknap

@gilesknap gilesknap commented Jun 21, 2026

Copy link
Copy Markdown
Owner

What this does

Starts tracking Cargo.lock. It was git-ignored, but this workspace builds an executable (the eyes2 binary; eyes2-lib is an unpublished path dependency, not a published library), so per Cargo's guidance the lock file should be committed for reproducible builds. The .gitignore even carried the standard reminder ("Remove Cargo.lock from gitignore if creating an executable").

Changes

  • Remove the Cargo.lock entry from .gitignore (replaced with a note explaining why it's now tracked).
  • Commit Cargo.lock, generated from the current main manifests.

Notes

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qb4gora6fHgAR5y1WQS6C1


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Updated repository configuration to include lock file in version control.

Cargo.lock was git-ignored, but the workspace produces the `eyes2` binary
(eyes2-lib is an unpublished path dependency, not a published library), so per
Cargo's guidance the lock file should be committed for reproducible builds.

Remove the `Cargo.lock` entry from .gitignore and commit the lock generated
from the current manifests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qb4gora6fHgAR5y1WQS6C1
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f0e8f80b-e346-495c-b8fc-801c4bf2af07

📥 Commits

Reviewing files that changed from the base of the PR and between 59d441d and 44075d3.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .gitignore

📝 Walkthrough

Walkthrough

The .gitignore file removes the rule that excluded Cargo.lock from version control and replaces it with comments explaining that Cargo.lock should be committed because this workspace builds an executable.

Changes

Cargo.lock Tracking

Layer / File(s) Summary
Remove Cargo.lock ignore rule
.gitignore
Replaces the Cargo.lock ignore entry with a comment stating the file should be committed for this executable workspace.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 Hop hop, no more hiding that lock,
The Cargo.lock stays right on the dock!
An executable needs its roots true,
Committed forever in version control's view.
✨ The bunny cheers — now nothing's amiss!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: tracking Cargo.lock with the rationale that the workspace builds an executable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/track-cargo-lock

Comment @coderabbitai help to get the list of available commands and usage tips.

@gilesknap
gilesknap merged commit dd9d086 into main Jun 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants