Track Cargo.lock (workspace builds an executable) - #11
Conversation
Cargo.lock was git-ignored, but the workspace produces the `eyes2` binary (eyes2-lib is an unpublished path dependency, not a published library), so per Cargo's guidance the lock file should be committed for reproducible builds. Remove the `Cargo.lock` entry from .gitignore and commit the lock generated from the current manifests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qb4gora6fHgAR5y1WQS6C1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesCargo.lock Tracking
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What this does
Starts tracking
Cargo.lock. It was git-ignored, but this workspace builds an executable (theeyes2binary;eyes2-libis an unpublished path dependency, not a published library), so per Cargo's guidance the lock file should be committed for reproducible builds. The.gitignoreeven carried the standard reminder ("Remove Cargo.lock from gitignore if creating an executable").Changes
Cargo.lockentry from.gitignore(replaced with a note explaining why it's now tracked).Cargo.lock, generated from the currentmainmanifests.Notes
gilescreature controller #5 → Parallelise the simulation across all cores (parallel think / serial resolve) #10 → Add giles assembler, disassembler and a TUI inspector #8); it touches only.gitignoreand addsCargo.lock, so it can merge tomainon its own with no conflicts.main's dependencies, so it does not yet containrayon(added by Parallelise the simulation across all cores (parallel think / serial resolve) #10). Once Parallelise the simulation across all cores (parallel think / serial resolve) #10 lands, the next build updates the lock to include it; happy to refresh it then if you'd like the entries in before that.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qb4gora6fHgAR5y1WQS6C1
Generated by Claude Code
Summary by CodeRabbit