Skip to content

Handle onError on YoutubePlayer #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
direx99 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle onError on YoutubePlayer #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions YouTubePlayer/YouTubePlayer/YouTubePlayer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ public enum YouTubePlayerEvents: String {
case Ready = "onReady"
case StateChange = "onStateChange"
case PlaybackQualityChange = "onPlaybackQualityChange"
case Error = "onError"

}

public enum YouTubePlaybackQuality: String {
Expand All @@ -38,6 +40,7 @@ public protocol YouTubePlayerDelegate: class {
func playerReady(_ videoPlayer: YouTubePlayerView)
func playerStateChanged(_ videoPlayer: YouTubePlayerView, playerState: YouTubePlayerState)
func playerQualityChanged(_ videoPlayer: YouTubePlayerView, playbackQuality: YouTubePlaybackQuality)
func playerEncounteredError(_ videoPlayer: YouTubePlayerView, errorMessage: String)
}

// Make delegate methods optional by providing default implementations
Expand All @@ -46,7 +49,7 @@ public extension YouTubePlayerDelegate {
func playerReady(_ videoPlayer: YouTubePlayerView) {}
func playerStateChanged(_ videoPlayer: YouTubePlayerView, playerState: YouTubePlayerState) {}
func playerQualityChanged(_ videoPlayer: YouTubePlayerView, playbackQuality: YouTubePlaybackQuality) {}

func playerEncounteredError(_ videoPlayer: YouTubePlayerView, errorMessage: String) {}
}

private extension URL {
Expand Down Expand Up @@ -348,7 +351,10 @@ open class YouTubePlayerView: UIView, WKNavigationDelegate {
playbackQuality = newQuality
delegate?.playerQualityChanged(self, playbackQuality: newQuality)
}


case .Error:
delegate?.playerEncounteredError(self, errorMessage: data ?? "Unknown error")

break
}
}
Expand Down