Skip to content

Conversation

@thinkerou
Copy link
Member

@thinkerou thinkerou commented Aug 20, 2018

ref: #1443

@thinkerou thinkerou added this to the 1.4 milestone Aug 20, 2018
@thinkerou thinkerou mentioned this pull request Sep 8, 2018
@thinkerou thinkerou closed this Sep 25, 2018
@thinkerou thinkerou deleted the else branch September 25, 2018 14:05
@thinkerou thinkerou restored the else branch September 25, 2018 14:22
@thinkerou thinkerou reopened this Sep 25, 2018
@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #1501 (04eb752) into master (dfc25f9) will decrease coverage by 0.50%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   98.75%   98.25%   -0.51%     
==========================================
  Files          41       43       +2     
  Lines        3059     3834     +775     
==========================================
+ Hits         3021     3767     +746     
- Misses         26       53      +27     
- Partials       12       14       +2     
Flag Coverage Δ
go-1.13 97.89% <0.00%> (-0.87%) ⬇️
go-1.14 97.73% <0.00%> (-0.87%) ⬇️
go-1.15 98.12% <20.00%> (-0.48%) ⬇️
go-1.16 98.11% <20.00%> (-0.48%) ⬇️
go-1.17 97.44% <24.00%> (?)
go-1.18 97.44% <24.00%> (?)
macos-latest 98.25% <20.00%> (-0.51%) ⬇️
nomsgpack 98.22% <20.00%> (-0.52%) ⬇️
ubuntu-latest 98.25% <20.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
render/reader.go 58.06% <0.00%> (-41.94%) ⬇️
render/render.go 100.00% <ø> (ø)
context.go 97.60% <35.29%> (-0.38%) ⬇️
mode.go 100.00% <0.00%> (ø)
tree.go 100.00% <0.00%> (ø)
routergroup.go 100.00% <0.00%> (ø)
binding/form.go 100.00% <0.00%> (ø)
binding/header.go 100.00% <0.00%> (ø)
binding/binding.go 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc25f9...04eb752. Read the comment docs.

@thinkerou thinkerou self-assigned this Dec 12, 2018
@thinkerou thinkerou modified the milestones: 1.4, 1.5 Mar 1, 2019
@thinkerou thinkerou modified the milestones: 1.5, 1.6 Oct 31, 2019
@thinkerou thinkerou modified the milestones: 1.6, 1.7 Feb 28, 2020
@appleboy
Copy link
Member

Add unit testing?

@niolap
Copy link

niolap commented Aug 12, 2020

@appleboy @javierprovecho Any chance to have that feature merge into the master? Would be very helpful when the content size is unknown in advance (which is our case when fetching rows from a database). Thank you

@appleboy
Copy link
Member

@thinkerou Please add unit testing.

@niolap
Copy link

niolap commented Aug 12, 2020

@thinkerou Please add unit testing.

@thinkerou, If you can do that, you'll make my day

@thinkerou thinkerou modified the milestones: 1.7, v1.8 Oct 21, 2020
@yashrsharma44
Copy link

Hi 👋
Any updates to this PR?
I could complete the requested changes if required.

@appleboy
Copy link
Member

  1. fix conflicts.
  2. add unit testing.

@thinkerou
Copy link
Member Author

Hi 👋
Any updates to this PR?
I could complete the requested changes if required.

@yashrsharma44 please, thanks a lot!!!

@thinkerou thinkerou removed this from the v1.8 milestone Nov 21, 2021
@thinkerou thinkerou added this to the v1.9 milestone Nov 21, 2021
@thinkerou thinkerou reopened this Jul 3, 2022
@thinkerou thinkerou modified the milestones: v1.9, v1.10 Jan 16, 2023
@appleboy
Copy link
Member

@thinkerou Add some testing case?

@appleboy appleboy modified the milestones: v1.10, v1.11 Mar 21, 2024
@appleboy
Copy link
Member

@thinkerou Please update the PR status?

@appleboy appleboy modified the milestones: v1.11, v1.12 Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants