export ErrUnknownType and code adjust for broken pipe and json invalid and use http.MethodGet instead of raw GET string and IsWebsocket check #2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2785 +/- ##
==========================================
- Coverage 98.77% 98.71% -0.07%
==========================================
Files 41 41
Lines 3106 2094 -1012
==========================================
- Hits 3068 2067 -1001
+ Misses 26 15 -11
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
appleboy
reviewed
Jul 13, 2021
binding/json.go
Outdated
| EnableDecoderDisallowUnknownFields = false | ||
|
|
||
| // JsonReqInvalid json invalid when request is nil or request body is nil. | ||
| JsonReqInvalid = errors.New("invalid request") |
There was a problem hiding this comment.
OK, I've adjusted it.
|
The name you said is OK, but the JSON request request is illegal. I'll adjust it appropriately.
…------------------ Original ------------------
From: Bo-Yi Wu ***@***.***>
Date: Tue,Jul 13,2021 9:46 AM
To: gin-gonic/gin ***@***.***>
Cc: heige ***@***.***>, Author ***@***.***>
Subject: Re: [gin-gonic/gin] export ErrUnknownType and code adjust for broken pipe and json invalid and use http.MethodGet instead of raw GET string and IsWebsocket check (#2785)
@appleboy commented on this pull request.
In binding/json.go:
> -// keys which do not match any non-ignored, exported fields in the destination. -var EnableDecoderDisallowUnknownFields = false +var ( +// EnableDecoderUseNumber is used to call the UseNumber method on the JSON +// Decoder instance. UseNumber causes the Decoder to unmarshal a number into an +// interface{} as a Number instead of as a float64. +EnableDecoderUseNumber = false + +// EnableDecoderDisallowUnknownFields is used to call the DisallowUnknownFields method +// on the JSON Decoder instance. DisallowUnknownFields causes the Decoder to +// return an error when the destination is a struct and the input contains object +// keys which do not match any non-ignored, exported fields in the destination. +EnableDecoderDisallowUnknownFields = false + +// JsonReqInvalid json invalid when request is nil or request body is nil. +JsonReqInvalid = errors.New("invalid request")
Maybe InvaildRequest?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
thinkerou
reviewed
Jul 22, 2021
| } | ||
|
|
||
| // IsBroken Check error for a broken connection | ||
| func IsBroken(err interface{}) bool { |
|
yes，I see that other components of gin are in use. Here, it is declared as an open method to facilitate reuse.
…------------------ Original ------------------
From: thinkerou ***@***.***>
Date: Thu,Jul 22,2021 8:00 AM
To: gin-gonic/gin ***@***.***>
Cc: heige ***@***.***>, Author ***@***.***>
Subject: Re: [gin-gonic/gin] export ErrUnknownType and code adjust for broken pipe and json invalid and use http.MethodGet instead of raw GET string and IsWebsocket check (#2785)
@thinkerou commented on this pull request.
In recovery.go:
> @@ -47,6 +47,20 @@ func RecoveryWithWriter(out io.Writer, recovery ...RecoveryFunc) HandlerFunc { return CustomRecoveryWithWriter(out, defaultHandleRecovery) } +// IsBroken Check error for a broken connection +func IsBroken(err interface{}) bool {
public method?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
kszafran
reviewed
Jul 30, 2021
binding/json.go
Outdated
| func (jsonBinding) Bind(req *http.Request, obj interface{}) error { | ||
| if req == nil || req.Body == nil { | ||
| return errors.New("invalid request") | ||
| return InvalidRequest |
There was a problem hiding this comment.
How about:
Suggested change
| return InvalidRequest | |
| return ErrInvalidRequest |
I think it's a common way to name errors.
There was a problem hiding this comment.
ok,thinks @kszafran
|
@daheige Please help to resolve conflicts. |
|
i have adjusted it ok, thinks.
原始邮件
发件人: Bo-Yi ***@***.***>
收件人: ***@***.***>
抄送: ***@***.***>; ***@***.***>
发送时间: 2022年4月16日(周六) 09:54
主题: Re: [gin-gonic/gin] export ErrUnknownType and code adjust for brokenpipe and json invalid and use http.MethodGet instead of raw GET string andIsWebsocket check (#2785)
@daheige Please help to resolve conflicts.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.export ErrUnknownType unknown request type
2.code adjust for broken pipe and json invalid and use http.MethodGet instead of raw GET string
3.IsWebsocket check