- 
                Notifications
    
You must be signed in to change notification settings  - Fork 8.5k
 
Add proto json rendering / binding #3317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
           I will take it.  | 
    
| 
           @appleboy - any chance you can review this? Should be pretty painless ;-)  | 
    
| 
           @Jarch09 I'm not a maintainer, I can't do anything here 😅  | 
    
          
 Understood. @appleboy @thinkerou  | 
    
| 
           @thinkerou @appleboy @Jarch09, can I somehow help with merging the PR?  | 
    
          
 Would love to get this merged in... lmk what needs to be done  | 
    
This adds the ability to directly render protobufs as JSON and bind to / unmarshal JSON payloads as protobufs.
Adds:
We need these new methods, because standard JSON encoding doesn't work with protobufs.