Bind: return 413 status code when error is http.MaxBytesError#3841
Closed
ItalyPaleAle wants to merge 4 commits intogin-gonic:masterfrom
Closed
Bind: return 413 status code when error is http.MaxBytesError#3841ItalyPaleAle wants to merge 4 commits intogin-gonic:masterfrom
http.MaxBytesError#3841ItalyPaleAle wants to merge 4 commits intogin-gonic:masterfrom
Conversation
The Go standard library includes a method `http.MaxBytesReader` that allows limiting the request body. For example, users can create a middleware like:
```go
func MiddlewareMaxBodySize(c *gin.Context) {
// Limit request body to 100 bytes
c.Request.Body = http.MaxBytesReader(c.Writer, c.Request.Body, 100)
c.Next()
}
```
When the body exceeds the limit, reading from the request body returns an error of type `http.MaxBytesError`.
This PR makes sure that when the error is of kind `http.MaxBytesError`, Gin returns the correct status code 413 (Request Entity Too Large) instead of a generic 400 (Bad Request).
Member
|
build fail. |
Contributor
Author
@appleboy looks like it's failing on the master branch too: https://github.com/gin-gonic/gin/actions/runs/7814638661/job/21316374466 Reason is that the "go.mod" file now uses Go 1.20, so the CI fails with 1.18 |
…equest-entity-too-large
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3841 +/- ##
==========================================
- Coverage 99.21% 98.99% -0.23%
==========================================
Files 42 41 -1
Lines 3182 3376 +194
==========================================
+ Hits 3157 3342 +185
- Misses 17 24 +7
- Partials 8 10 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go standard library includes a method
http.MaxBytesReaderthat allows limiting the request body. For example, users can create a middleware like:When the body exceeds the limit, reading from the request body returns an error of type
http.MaxBytesError.This PR makes sure that when the error is of kind
http.MaxBytesError, Gin returns the correct status code 413 (Request Entity Too Large) instead of a generic 400 (Bad Request).