feat(context): add SaveUploadedFileToRoot with root-constrained uploa…#4590
Open
tangerineyu wants to merge 2 commits intogin-gonic:masterfrom
Open
feat(context): add SaveUploadedFileToRoot with root-constrained uploa…#4590tangerineyu wants to merge 2 commits intogin-gonic:masterfrom
tangerineyu wants to merge 2 commits intogin-gonic:masterfrom
Conversation
8c3e371 to
1658e4e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4590 +/- ##
==========================================
- Coverage 99.21% 98.32% -0.90%
==========================================
Files 42 48 +6
Lines 3182 3160 -22
==========================================
- Hits 3157 3107 -50
- Misses 17 43 +26
- Partials 8 10 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4488
Summary
This PR adds SaveUploadedFileToRoot, a safer upload API that constrains all filesystem operations within os.Root, preventing path traversal and symlink escape writes.
Why
SaveUploadedFile is convenient, but when destination paths may be influenced by user input, writes should be constrained to a fixed upload root.
What changed
Tests
Compatibility / Risk