Skip to content

refactor(binding): use idiomatic range loop for SliceValidationError#4620

Open
preetham690 wants to merge 2 commits intogin-gonic:masterfrom
preetham690:improve-slice-error-iteration
Open

refactor(binding): use idiomatic range loop for SliceValidationError#4620
preetham690 wants to merge 2 commits intogin-gonic:masterfrom
preetham690:improve-slice-error-iteration

Conversation

@preetham690
Copy link
Copy Markdown

Replaced a non-idiomatic loop (for i := range len(err))
with a standard Go range loop (for i, e := range err).

This improves readability and aligns with Go best practices
without changing behavior

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.37%. Comparing base (3dc1cd6) to head (1c24d19).
⚠️ Report is 275 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4620      +/-   ##
==========================================
- Coverage   99.21%   98.37%   -0.84%     
==========================================
  Files          42       48       +6     
  Lines        3182     3138      -44     
==========================================
- Hits         3157     3087      -70     
- Misses         17       42      +25     
- Partials        8        9       +1     
Flag Coverage Δ
?
--ldflags="-checklinkname=0" -tags sonic 98.36% <100.00%> (?)
-tags go_json 98.29% <100.00%> (?)
-tags nomsgpack 98.35% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 ?
go-1.25 98.37% <100.00%> (?)
go-1.26 98.37% <100.00%> (?)
macos-latest 98.37% <100.00%> (-0.84%) ⬇️
ubuntu-latest 98.37% <100.00%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@preetham690
Copy link
Copy Markdown
Author

This change is completely a refactor and does not alter any behavior.
Existing tests for SliceValidationError continue to pass.

Please let me know if additional test coverage is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant