RS-coarsening reference implementation#1985
Open
gojakuch wants to merge 13 commits into
Open
Conversation
ginkgo-bot
added
reg:build
Member
|
FYI, #1978 will likely require some changes in your kernel function signatures to match the changes there |
gojakuch
force-pushed
the
feat/rs-coarsening
branch
from
ab79a98 to
e5e08d3
Compare
gojakuch
force-pushed
the
feat/rs-coarsening
branch
from
33ac013 to
5010a34
Compare
Collaborator
Author
|
now that #1978 is merged, I know I need to adapt the kernels. I'll do that. for now, committing what I've got so far and rebasing |
pratikvn
reviewed
Mar 24, 2026
Member
pratikvn
left a comment
pratikvn
left a comment
There was a problem hiding this comment.
Nice work! For the most part, I think the sturucture looks good! I think some kernels can be merged.
gojakuch
force-pushed
the
feat/rs-coarsening
branch
2 times, most recently
from
6c62180 to
79522c4
Compare
gojakuch
force-pushed
the
feat/rs-coarsening
branch
from
79522c4 to
8df1133
Compare
gojakuch
force-pushed
the
feat/rs-coarsening
branch
from
8df1133 to
a813399
Compare
pratikvn
requested changes
May 7, 2026
pratikvn
requested changes
May 11, 2026
Member
pratikvn
left a comment
pratikvn
left a comment
There was a problem hiding this comment.
Just missing core tests. Otherwise looks good!
| strength_threshold, 0.25); | ||
|
|
||
| bool GKO_FACTORY_PARAMETER_SCALAR(skip_sorting, false); | ||
|
|
Member
There was a problem hiding this comment.
Add a short documentation string for this parameter
Comment on lines
+72
to
+78
| GKO_CREATE_FACTORY_PARAMETERS(parameters, Factory) | ||
| { | ||
| /** | ||
| * Strength-of-connection threshold, theta | ||
| */ | ||
| remove_complex<value_type> GKO_FACTORY_PARAMETER_SCALAR( | ||
| strength_threshold, 0.25); |
Member
There was a problem hiding this comment.
The core tests seem to be missing. Can you add them ? See core/test/multigrid/pgm.cpp as an example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the reference implementation for RS-coarsening