Skip to content

Hybrid device view#2004

Open
MarcelKoch wants to merge 2 commits into
developfrom
hybrid-device-view
Open

Hybrid device view#2004
MarcelKoch wants to merge 2 commits into
developfrom
hybrid-device-view

Conversation

@MarcelKoch
Copy link
Copy Markdown
Member

@MarcelKoch MarcelKoch commented Apr 16, 2026

This PR adds a device view for the matrix::Hybrid class.

@MarcelKoch MarcelKoch requested review from pratikvn and yhmtsai April 16, 2026 13:03
@MarcelKoch MarcelKoch self-assigned this Apr 16, 2026
@MarcelKoch MarcelKoch added the 1:ST:ready-for-review This PR is ready for review label Apr 16, 2026
@ginkgo-bot ginkgo-bot added reg:testing This is related to testing. type:matrix-format This is related to the Matrix formats type:reordering This is related to the matrix(LinOp) reordering mod:all This touches all Ginkgo modules. labels Apr 16, 2026
MarcelKoch
MarcelKoch commented Apr 16, 2026
View reviewed changes
Comment thread include/ginkgo/core/matrix/device_views.hpp Outdated
yhmtsai
yhmtsai requested changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly on the another test for assert.

Comment thread core/test/matrix/hybrid.cpp
Comment thread include/ginkgo/core/matrix/device_views.hpp Outdated
@MarcelKoch MarcelKoch requested a review from yhmtsai April 17, 2026 09:43
@MarcelKoch MarcelKoch added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels May 11, 2026
MarcelKoch and others added 2 commits May 11, 2026 15:42
@MarcelKoch @yhmtsai
add view::hybrid for kernels
0441657 
Co-authored-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>
@MarcelKoch
use view::hybrid in other kernels
8ec5467
@MarcelKoch MarcelKoch force-pushed the hybrid-device-view branch from a86b8b0 to 8ec5467 Compare May 11, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yhmtsai yhmtsai yhmtsai approved these changes

@pratikvn pratikvn Awaiting requested review from pratikvn

Assignees

@MarcelKoch MarcelKoch

Labels

1:ST:ready-to-merge This PR is ready to merge. mod:all This touches all Ginkgo modules. reg:testing This is related to testing. type:matrix-format This is related to the Matrix formats type:reordering This is related to the matrix(LinOp) reordering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcelKoch @yhmtsai @ginkgo-bot