Merged
Conversation
Chris7
commented
Jan 10, 2025
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct ChangesetModels { |
Contributor
Author
There was a problem hiding this comment.
all models aren't in here, should extend when needed.
Chris7
commented
Jan 10, 2025
| let mut previous_edges = HashSet::new(); | ||
| let mut previous_paths = HashSet::new(); | ||
| let mut previous_accessions = HashSet::new(); | ||
| let mut previous_nodes = HashSet::new(); |
Contributor
Author
There was a problem hiding this comment.
this was missing when nodes were added
Chris7
commented
Jan 10, 2025
| contents | ||
| } | ||
|
|
||
| fn parse_string(item: &ChangesetItem, col: usize) -> String { |
Contributor
Author
There was a problem hiding this comment.
makes the parsing out of this stuff a lot easier
dkhofer
reviewed
Jan 10, 2025
| hash: parse_maybe_string(item, 2), | ||
| }); | ||
| } | ||
| "edges" => created_edges.push(Edge { |
Contributor
There was a problem hiding this comment.
I didn't realize brackets weren't needed for matching. Maybe do the same for the other one liners here?
dkhofer
reviewed
Jan 10, 2025
src/views/patch.rs
Outdated
| use std::io::Read; | ||
|
|
||
| pub fn view_patches(patches: &[OperationPatch]) -> HashMap<String, HashMap<i64, String>> { | ||
| // For each blockgroup in a patch, a |
dkhofer
approved these changes
Jan 10, 2025
Contributor
dkhofer
left a comment
dkhofer
left a comment
There was a problem hiding this comment.
LGTM, comments are minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will generate a .dot file from a patch. It's some of the starting work to explore how we can show changes to users in reviews, etc