Conversation
Chris7
commented
Feb 21, 2025
| @@ -1,9 +1,13 @@ | |||
| use crate::graph::{GraphEdge, GraphNode}; | |||
Contributor
Author
There was a problem hiding this comment.
this file was changed to let the block graph generated be called externally
bobvh
reviewed
Feb 21, 2025
| } | ||
|
|
||
| pub fn view_operations(conn: &Connection, operations: &[Operation]) -> Result<(), io::Error> { | ||
| fn restore_terminal() { |
Contributor
There was a problem hiding this comment.
Have you confirmed that this actually does something if you use the Ratatui init?
Contributor
There was a problem hiding this comment.
Stack trace saving would have to be a separate hook, so I don't know if there's any benefit from combining approaches.
Contributor
|
Looks good and still works on my end. Cool that you moved the keyboard handling and status bar over to the widget. |
bobvh
reviewed
Feb 21, 2025
| @@ -68,7 +89,18 @@ pub fn view_operations(conn: &Connection, operations: &[Operation]) -> Result<() | |||
| let mut terminal = Terminal::new(backend)?; | |||
Contributor
There was a problem hiding this comment.
Here's where let mut terminal = ratatui::init(); could come in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.