feat(upload): save selected user row info #2697
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+48
to
+51
| # .reject do |user_row| | ||
| # user_row.last_user_save_attempt.success? | ||
| # end | ||
| user_rows.select(&:user_valid?).select(&:marked_for_user_save?) |
There was a problem hiding this comment.
J'ai le sentiment qu'ici on ne devrait pas prendre ceux qui sont déjà créés non ? Avec le code en commentaire
Comment on lines
+71
to
+74
| # .reject do |user_row| | ||
| # user_row.invitation_succeeded? | ||
| # end | ||
| user_rows.select(&:marked_for_invitation?).select(&:user_save_succeded?) |
There was a problem hiding this comment.
Idem ici, j'imagine qu'on ne veut pas ceux qui ont déjà été invités ?
Comment on lines
+200
to
+202
| def invitation_succeeded? | ||
| invitation_attempts.any?(&:success?) | ||
| end |
There was a problem hiding this comment.
Uniquement nécessaire si le code cité au dessus l'est
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR permet une amélioration de la gestion de la sélection. La sélection est désormais sauvegardée côté serveur immédiatement. Cela permet de ne pas avoir à envoyer la toute sélection au moment de l'envoi des invitations et des créations de compte.
fix #2674