NewUpload(ux): preventing row edition if saves are not finished #2741
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holist
requested review from
aminedhobb and
Michaelvilleneuve
and removed request for
aminedhobb
aminedhobb
reviewed
Apr 1, 2025
There was a problem hiding this comment.
Merci @Holist , je t'ai posé deux questions pour savoir si on pouvait pas simplifier un peu plus
app/views/user_list_uploads/user_save_attempts/_user_row.html.erb
Outdated
Show resolved
Hide resolved
app/views/user_list_uploads/user_save_attempts/_user_row.html.erb
Outdated
Show resolved
Hide resolved
app/views/user_list_uploads/user_save_attempts/_user_row.html.erb
Outdated
Show resolved
Hide resolved
aminedhobb
reviewed
Apr 1, 2025
There was a problem hiding this comment.
Merci @Holist pour les changements 🙏 !
J'ai encore quelques questions mais sinon LGTM 👍
app/views/user_list_uploads/user_save_attempts/_user_row.html.erb
Outdated
Show resolved
Hide resolved
app/views/user_list_uploads/user_save_attempts/_user_row.html.erb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2736
Enregistrement.de.l.ecran.2025-03-21.a.16.56.01.mp4