Bump FSharp.SystemTextJson and 3 others #667
Conversation
Bumps FSharp.SystemTextJson from 1.3.13 to 1.4.36 Bumps Microsoft.NET.Test.Sdk from 17.12.0 to 17.14.1 Bumps System.Text.Json from 8.0.6 to 9.0.7 Bumps xunit.runner.visualstudio from 3.0.2 to 3.1.3 --- updated-dependencies: - dependency-name: FSharp.SystemTextJson dependency-version: 1.4.36 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 17.14.1 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: System.Text.Json dependency-version: 9.0.7 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
.NET
There was a problem hiding this comment.
Pull Request Overview
This PR updates several NuGet package dependencies to their latest versions, including core JSON handling libraries and testing tools. The changes also normalize quote usage in MSBuild configuration files.
- Updated FSharp.SystemTextJson and System.Text.Json to newer major versions (1.3.x → 1.4.x and 8.0.x → 9.0.x respectively)
- Updated testing dependencies Microsoft.NET.Test.Sdk and xunit.runner.visualstudio to latest versions
- Standardized quote character usage in MSBuild analyzer configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Giraffe/Giraffe.fsproj | Updates core JSON serialization dependencies to newer major versions |
| tests/Giraffe.Tests/Giraffe.Tests.fsproj | Updates test framework dependencies to latest versions |
| Directory.Build.targets | Normalizes quote characters in F# analyzer configuration |
| <PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="3.0.*" /> | ||
| <PackageReference Include="System.Text.Json" Version="8.0.*" /> | ||
| <PackageReference Include="FSharp.SystemTextJson" Version="1.3.*" /> | ||
| <PackageReference Include="System.Text.Json" Version="9.0.7" /> |
There was a problem hiding this comment.
Updating System.Text.Json from 8.0.* to 9.0.7 represents a major version change that could introduce breaking changes. Consider verifying that all existing JSON serialization behavior remains compatible, especially around null handling, property naming policies, and custom converters.
| <PackageReference Include="System.Text.Json" Version="9.0.7" /> | |
| <PackageReference Include="System.Text.Json" Version="8.0.*" /> |
| <PackageReference Include="System.Text.Json" Version="8.0.*" /> | ||
| <PackageReference Include="FSharp.SystemTextJson" Version="1.3.*" /> | ||
| <PackageReference Include="System.Text.Json" Version="9.0.7" /> | ||
| <PackageReference Include="FSharp.SystemTextJson" Version="1.4.36" /> |
There was a problem hiding this comment.
The FSharp.SystemTextJson update from 1.3.* to 1.4.36 should be tested for compatibility with the new System.Text.Json 9.0.7. Major version updates in both packages simultaneously could compound potential breaking changes in F# record and union type serialization.
| <PackageReference Include="FSharp.SystemTextJson" Version="1.4.36" /> | |
| <PackageReference Include="FSharp.SystemTextJson" Version="1.3.*" /> |
|
Superseded by #668. |
Performed the following updates:
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)