-
Notifications
You must be signed in to change notification settings - Fork 2
Improve evaluations, matrix copies and add new features for PDEs and integration #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Albe21072000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it is all OK, the only issue is with the plot visualization in VScode, which requires the method display instead of gui.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the single‐basis evaluation API, unifies size implementations, and refactors matrix I/O/ownership semantics while adding sparse‐matrix and PDE support.
- Renamed
evalSingle/derivSingle/deriv2Singletoval/deriv/deriv2and routed through newcomputeAPI - Replaced custom
Gismo.sizewithBase.sizeonBasis,KnotVector,MultiPatch, etc. - Refactored matrix functions (
asMatrix→copyMatrix,asVector→copyVector) and introduced sparse‐matrix exports and new PDE & FunctionExpr types
Reviewed Changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/runtests.jl | Switched to size, added val/deriv/deriv2 tests, sparse support |
| src/gsCore.jl | Replaced evalSingle fns, updated Base.size, added compute, getElements, boundary, boundaryOffset |
| src/gsMatrix.jl | Renamed ownership wrappers to copyMatrix/copyVector, added sparse‐matrix support |
| src/gsHSplines.jl | Added tensorLevel, getLevelAtPoint, getElementData |
| src/gsPde.jl | Introduced BoundaryConditions, addCondition!, addCornerValue!, setGeoMap! |
| src/gsNurbs.jl | Updated size for KnotVector, pipe API for NurbsAnnulus |
| src/Declarations.jl | Declared new C‐pointer structs (gsCVectorInt, gsCSparseMatrix, gsCFunctionExpr, gsCBoundaryConditions) |
| src/Gismo.jl | Included new gsPde.jl submodule |
| test/runbenchmarks.jl | Removed unused import of Gismo.size |
| examples/*.jl | Updated example calls to use copyMatrix/copyVector and new APIs |
Co-authored-by: Copilot <[email protected]>
size and change functions for single basis function evaluations
NEW:
API:
asMatrixandtoMatrixand addcopyMatrixsince there were issues in garbage collectionFIXED: