Skip to content

Conversation

@Crazy-Rich-Meghan
Copy link
Contributor

No description provided.

@Crazy-Rich-Meghan Crazy-Rich-Meghan added this to the v25.06.0 milestone Jun 25, 2025
@Crazy-Rich-Meghan Crazy-Rich-Meghan self-assigned this Jun 25, 2025
@Crazy-Rich-Meghan Crazy-Rich-Meghan added the enhancement New feature or request label Jun 25, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates boundary condition functions to support multi‐patch scenarios by modifying how temperature and Neumann functions are evaluated.

  • In gsVisitorThermoBoundary.h, the conditional branch for evaluating temperature in the physical domain has been removed, and evaluation now always uses piece-based evaluation.
  • In gsVisitorElasticityNeumann.h, a new variable (currentPatch) is introduced and assigned from patchIndex to allow multi‐patch evaluation of the Neumann function.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/gsVisitorThermoBoundary.h Removed the conditional branch for physical domain evaluation for temperature.
src/gsVisitorElasticityNeumann.h Introduced currentPatch and updated the Neumann function evaluation to use it.
Comments suppressed due to low confidence (2)

src/gsVisitorElasticityNeumann.h:110

  • [nitpick] Consider clarifying the inline comment for 'currentPatch' to explicitly explain its role in supporting multi-patch evaluation.
    index_t currentPatch; //gsLOOKUPFUNCTION

src/gsVisitorThermoBoundary.h:65

  • The removal of the conditional branch may cause the evaluation in the physical domain to be skipped when paramTemp is false. Please verify that this change in temperature evaluation logic is intentional.
        if (paramTemp)

@hverhelst hverhelst merged commit 66c236c into master Jun 27, 2025
3 checks passed
@hverhelst hverhelst deleted the hot-fix-neumann branch June 27, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants