Reorder the directories add scripts for cleaning, running and linking; update precice function documentation for doxygen #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crazy-Rich-Meghan
added
documentation
hverhelst
reviewed
Dec 5, 2024
Member
hverhelst
left a comment
hverhelst
left a comment
There was a problem hiding this comment.
Very neat, thanks! I like the file re-organization.
I suggested some changes, please check for left-over gsDebug statements.
In addition, I changed some things in the CI configuration. Hopefully, gsElasticity will be included. I will wait for the CI to finish until I give further comments.
For now, great work!
Member
There was a problem hiding this comment.
We need to see if these files are needed. Since they have relative paths to hard-coded build folder names, it is not very nice
Member
There was a problem hiding this comment.
Are these changes conforming the precice-config.xml provided in the original tutorial?
add perform CI only on `gsPreCICE-examples`
Updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example structure is reordered as the following:
benchmark-name/benchmark-coupling-methodI/participantA/run.shclean.shgismo-executable/create_symlink.shparticipantB/run.shclean.shbenchmark-coupling-methodII/...
benchmark-file.cpp