Skip to content

Conversation

@Crazy-Rich-Meghan
Copy link
Contributor

  • Use shell mid-plane to represent elasticity
  • Coupled with OpenFOAM via vertex-vertex communication method
  • Use volume for visualization

@Crazy-Rich-Meghan Crazy-Rich-Meghan added the enhancement New feature or request label Mar 20, 2025
@Crazy-Rich-Meghan Crazy-Rich-Meghan self-assigned this Mar 20, 2025
Copy link
Member

@hverhelst hverhelst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite some left-over sections commented out, and gsDebugVar calls left in the code. Would be nice to give it a small clean-up.
In addition, try to comment a bit more sections. Maybe we can accompany the file with a .dox file, so that it'll be documented immediately; this is a good practice anyay.
Lastly, it would be nice to have the update of the shell volume (inside the time-loop) as just a function call,i.e. constructShellVolume(mid_surface,thickness) (and maybe some direction to indicate which direction the thickness acts). Is this possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants