-
Notifications
You must be signed in to change notification settings - Fork 1
Multi-patch coupling support #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces multi-patch support to the lookup function API and updates the perpendicular-flap example to use the new functionality.
- Added a
gsLookupFunctionwrapper class managing multiplegsLookupFunctionSingleinstances - Renamed and refactored the original
gsLookupFunctiontogsLookupFunctionSingle, adjusting storage and warnings - Updated the perpendicular-flap example to build and use a multi-patch lookup function for stress data
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gsLookupFunction.h | Added multipatch wrapper class, refactored single-patch lookup into gsLookupFunctionSingle |
| examples/perpendicular-flap-multipatch-vertex-gismo.cpp | New example using multi-patch lookup and updated coupling logic |
Comments suppressed due to low confidence (3)
examples/perpendicular-flap-multipatch-vertex-gismo.cpp:1
- The
@fileannotation doesn’t match this filename; update it toperpendicular-flap-multipatch-vertex-gismo.cppto avoid confusion.
/** @file solid-gismo-elasticity.cpp
gsLookupFunction.h:92
- [nitpick] This override always throws an error advising to use the patch-specific overload; consider marking these no-ops as
= deleteto prevent accidental misuse.
void eval_into(const gsMatrix<T>& u, gsMatrix<T>& result) const override
gsLookupFunction.h:40
- [nitpick] No unit tests cover the new multi-patch lookup functionality; adding tests for construction,
add/set, and evaluation across patches would improve reliability.
gsLookupFunction(size_t nPatches = 0)
Feature added: