Revert "Add support for macOS enterprise deployable default settings"

docs/enterprise-config.md

@@ -55,38 +55,7 @@ those of the [Git configuration][config] settings.
 The type of each registry key can be either `REG_SZ` (string) or `REG_DWORD`
 (integer).
 
-## macOS
-
-Default settings values come from macOS's preferences system. Configuration
-profiles can be deployed to devices using a compatible Mobile Device Management
-(MDM) solution.
-
-Configuration for Git Credential Manager must take the form of a dictionary, set
-for the domain `git-credential-manager` under the key `configuration`. For
-example:
-
-```shell
-defaults write git-credential-manager configuration -dict-add <key> <value>
-```
-
-..where `<key>` is the name of the settings from the [Git configuration][config]
-reference, and `<value>` is the desired value.
-
-All values in the `configuration` dictionary must be strings. For boolean values
-use `true` or `false`, and for integer values use the number in string form.
-
-To read the current configuration:
-
-```console
-$ defaults read git-credential-manager configuration
-{
-    <key1> = <value1>;
-    ...
-    <keyN> = <valueN>;
-}
-```
-
-## Linux
+## macOS/Linux
 
 Default configuration setting stores has not been implemented.
 

src/shared/Core/CommandContext.cs

@@ -131,7 +131,7 @@ public CommandContext()
                                             gitPath,
                                             FileSystem.GetCurrentDirectory()
                                         );
-                Settings          = new MacOSSettings(Environment, Git, Trace);
+                Settings          = new Settings(Environment, Git);
             }
             else if (PlatformUtils.IsLinux())
             {

src/shared/Core/Constants.cs

@@ -16,7 +16,6 @@ public static class Constants
 
         public const string GcmDataDirectoryName = ".gcm";
 
-        public const string MacOSBundleId = "git-credential-manager";
         public static readonly Guid DevBoxPartnerId = new("e3171dd9-9a5f-e5be-b36c-cc7c4f3f3bcf");
 
         /// <summary>

src/shared/Core/Interop/MacOS/MacOSKeychain.cs

@@ -302,18 +302,35 @@ private static string GetStringAttribute(IntPtr dict, IntPtr key)
                 return null;
             }
 
-            if (CFDictionaryGetValueIfPresent(dict, key, out IntPtr value) && value != IntPtr.Zero)
+            IntPtr buffer = IntPtr.Zero;
+            try
             {
-                if (CFGetTypeID(value) == CFStringGetTypeID())
+                if (CFDictionaryGetValueIfPresent(dict, key, out IntPtr value) && value != IntPtr.Zero)
                 {
-                    return CFStringToString(value);
+                    if (CFGetTypeID(value) == CFStringGetTypeID())
+                    {
+                        int stringLength = (int)CFStringGetLength(value);
+                        int bufferSize = stringLength + 1;
+                        buffer = Marshal.AllocHGlobal(bufferSize);
+                        if (CFStringGetCString(value, buffer, bufferSize, CFStringEncoding.kCFStringEncodingUTF8))
+                        {
+                            return Marshal.PtrToStringAuto(buffer, stringLength);
+                        }
+                    }
+
+                    if (CFGetTypeID(value) == CFDataGetTypeID())
+                    {
+                        int length = CFDataGetLength(value);
+                        IntPtr ptr = CFDataGetBytePtr(value);
+                        return Marshal.PtrToStringAuto(ptr, length);
+                    }
                 }
-
-                if (CFGetTypeID(value) == CFDataGetTypeID())
+            }
+            finally
+            {
+                if (buffer != IntPtr.Zero)
                 {
-                    int length = CFDataGetLength(value);
-                    IntPtr ptr = CFDataGetBytePtr(value);
-                    return Marshal.PtrToStringAuto(ptr, length);
+                    Marshal.FreeHGlobal(buffer);
                 }
             }