mingw_rename: support ReFS on Windows 2022 #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReFS is an alternative filesystem to NTFS. On Windows 2022, it seems not to support the rename operation using POSIX semantics that Git uses on Windows as of 391bcea (compat/mingw: support POSIX semantics for atomic renames, 2024-10-27). However, Windows 2022 reports `ERROR_NOT_SUPPORTED` in this instance. This is in contrast to `ERROR_INVALID_PARAMETER` (as previous Windows versions would report that do not support POSIX semantics in renames at all). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics. This fixes #5427 Signed-off-by: Johannes Schindelin <[email protected]>
rimrul
approved these changes
Mar 26, 2025
|
/add relnote bug On Windows Server 2022, Git v2.48.1 introduced a regression where it failed to write files on ReFS drives, which was fixed. The workflow run was started |
github-actions bot
pushed a commit
to git-for-windows/build-extra
that referenced
this pull request
Mar 26, 2025
On Windows Server 2022, Git v2.48.1 introduced a regression where it [failed to write files on ReFS drives](git-for-windows/git#5427), which was [fixed](git-for-windows/git#5515). Signed-off-by: gitforwindowshelper[bot] <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 26, 2025
Git on Windows 2022 fails to write config files on ReFS with the error message "Function not implemented". The reason is that `ERROR_NOT_SUPPORTED` is reported (not `ERROR_INVALID_PARAMETER`, as expected). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics. This fixes #5427
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 26, 2025
Git on Windows 2022 fails to write config files on ReFS with the error message "Function not implemented". The reason is that `ERROR_NOT_SUPPORTED` is reported (not `ERROR_INVALID_PARAMETER`, as expected). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics. This fixes #5427
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 26, 2025
Git on Windows 2022 fails to write config files on ReFS with the error message "Function not implemented". The reason is that `ERROR_NOT_SUPPORTED` is reported (not `ERROR_INVALID_PARAMETER`, as expected). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics. This fixes #5427
dscho
added a commit
that referenced
this pull request
Mar 26, 2025
Git on Windows 2022 fails to write config files on ReFS with the error message "Function not implemented". The reason is that `ERROR_NOT_SUPPORTED` is reported (not `ERROR_INVALID_PARAMETER`, as expected). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics. This fixes #5427
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 28, 2025
Git on Windows 2022 fails to write config files on ReFS with the error message "Function not implemented". The reason is that `ERROR_NOT_SUPPORTED` is reported (not `ERROR_INVALID_PARAMETER`, as expected). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics. This fixes #5427
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 28, 2025
Git on Windows 2022 fails to write config files on ReFS with the error message "Function not implemented". The reason is that `ERROR_NOT_SUPPORTED` is reported (not `ERROR_INVALID_PARAMETER`, as expected). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics. This fixes #5427
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 28, 2025
Git on Windows 2022 fails to write config files on ReFS with the error message "Function not implemented". The reason is that `ERROR_NOT_SUPPORTED` is reported (not `ERROR_INVALID_PARAMETER`, as expected). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics. This fixes #5427
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 29, 2025
Git on Windows 2022 fails to write config files on ReFS with the error message "Function not implemented". The reason is that `ERROR_NOT_SUPPORTED` is reported (not `ERROR_INVALID_PARAMETER`, as expected). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics. This fixes #5427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git on Windows 2022 fails to write config files on ReFS with the error message "Function not implemented". The reason is that
ERROR_NOT_SUPPORTEDis reported (notERROR_INVALID_PARAMETER, as expected). Let's handle both errors the same: by falling back to the best-effort option, namely to rename without POSIX semantics.This fixes #5427