fix : Avatar 컴포넌트 리팩토링#820
Merged
Merged
Conversation
ytaek
previously approved these changes
Aug 4, 2025
Comment on lines
+1
to
+12
| export const AVATAR_STYLE = { | ||
| width: 30, | ||
| height: 30, | ||
| minWidth: 30, | ||
| minHeight: 30, | ||
| } as const; | ||
|
|
||
| export const TOOLTIP_STYLE = { | ||
| ".MuiTooltip-tooltip": { | ||
| bgcolor: "#3c4048", | ||
| }, | ||
| } as const; |
|
|
||
| const Author = ({ name, src }: AuthorInfo) => { | ||
| const isUser = src.includes(GITHUB_URL); | ||
| const AvatarComponent = isGitHubUser(src) ? ClickableAvatar : StaticAvatar; |
Contributor
There was a problem hiding this comment.
component의 변수로 빼도 괜찮지만,
오히려 AvatarComponent라는 component를 밖으로 뺴는 것도 괜찮을 것 같습니다!
Contributor
Author
There was a problem hiding this comment.
그러네요! 굳이 컴포넌트 내 변수로 남기지 않아도 되겠네요!
이 부분도 반영해서 추가 커밋 남기겠습니다!
감사합니다👍
SingTheCode
approved these changes
Aug 8, 2025
| import { AVATAR_STYLE, TOOLTIP_STYLE } from "./Author.const"; | ||
|
|
||
| const isGitHubUser = (src: string): boolean => { | ||
| return src.startsWith(GITHUB_URL); |
Contributor
There was a problem hiding this comment.
사소한 부분이지만 의미가 더 명확하게 변경되어서 좋은 것 같습니다ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
#818
Result
Author컴포넌트에서isUser여부에 따라 각각 다른 컴포넌트 두 개를 렌더하는 부분을,ClickableAvatar와StaticAvatar컴포넌트로 분리하였습니다.Discussion