fix(vscode): repo 변수에서 잘못된 배열 접근 제거#843
Merged
ethandeveloper2 merged 1 commit intoAug 19, 2025
Merged
Conversation
grapefruit13
approved these changes
Aug 18, 2025
grapefruit13
left a comment
grapefruit13
left a comment
Contributor
There was a problem hiding this comment.
LGTM!!!
이 부분을 찾아내시다니 엄청 예리하시네요 👍🏻👍🏻👍🏻
SingTheCode
approved these changes
Aug 18, 2025
SingTheCode
left a comment
SingTheCode
left a comment
Contributor
There was a problem hiding this comment.
어떻게 찾으신거죠ㅎㅎㅎ 고생하셨습니다ㅎㅎ
| const gitLog = await getGitLog(gitPath, currentWorkspacePath); | ||
| const { owner, repo: initialRepo } = getRepo(gitConfig); | ||
| const repo = initialRepo[0]; | ||
| const repo = initialRepo; |
ytaek
approved these changes
Aug 18, 2025
Contributor
There was a problem hiding this comment.
이거 blame을 돌려봐야하는걸까요? 😈😈😈
해당 부분에 대한 test case 가 존재하지 않아서 이런 오류를 못 잡았을 수도 있겠습니다!
Test를 맡으신 @grapefruit13 님, @ethandeveloper2 님 관련해서 Test case를 추가하는걸 이슈로 등록하고 진행해주시면 어떨까요? 😸
| const gitLog = await getGitLog(gitPath, currentWorkspacePath); | ||
| const { owner, repo: initialRepo } = getRepo(gitConfig); | ||
| const repo = initialRepo[0]; | ||
| const repo = initialRepo; |
Contributor
Author
현재 getRepo라는 단일 함수 자체에 대한 테스트가 충분히 작성되어 있는 상황이기 떄문에, |
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
closes #839
Result