refactor: DI 컨테이너 변수명 변경#910
Merged
Merged
Conversation
ytaek
approved these changes
Sep 30, 2025
ytaek
left a comment
ytaek
left a comment
Contributor
There was a problem hiding this comment.
PR description이 충분히 상세해서 이해하는데 많은 도움이 되네요!!
LGGGGTM!!
chae-dahee
approved these changes
Sep 30, 2025
chae-dahee
left a comment
chae-dahee
left a comment
Contributor
There was a problem hiding this comment.
LGTM!! 빠르게 코드리뷰 반영해주셔서 너무 좋네요~ 문서와 코드로 충분히 설명된 것 같습니다👍 고생하셨습니당ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Related issue: #898
리뷰 피드백 반영으로 DI 컨테이너 변수명을 리네이밍합니다.
Result
Work list
container->diContainer로 변경하였습니다.*변경 범위가 작아 view/engine을 통합하여 업로드합니다.
Discussion
디렉터리/파일명은 container로 유지하였습니다.