refactor(view) : 스토리라인 차트 디자인 변경#943
Merged
Merged
Conversation
ytaek
approved these changes
Oct 8, 2025
ytaek
left a comment
ytaek
left a comment
Contributor
There was a problem hiding this comment.
점점 체계를 잡아가고 있는 것 같습니다!! 이뻐지고 있네요!!
LPrettyTM!!!
Comment on lines
+104
to
+106
| .style("font-size", "12px") | ||
| .style("fill", "#b4bac6") | ||
| .style("font-weight", "500") |
Contributor
There was a problem hiding this comment.
코드가 넘 복잡해지는 것 같다면, 이런것들도 전부 class 로 빼도 괜찮겠습니다.
| .style("font-size", "12px") | ||
| .style("fill", "#b4bac6") | ||
| .style("font-weight", "500") | ||
| .style("cursor", (folderPath: string) => { |
Contributor
There was a problem hiding this comment.
data 의 typing은 위에서 d3.selection할 때 먹일 수도 있습니다!
(쓸데없는 generic까지 많아서 좀 귀찮긴 하지만)
hyemimi
approved these changes
Oct 8, 2025
hyemimi
left a comment
hyemimi
left a comment
Contributor
There was a problem hiding this comment.
LGTM입니다 !! 수고 많으셨어요! 예쁘게 만들어주셔서 감사합니다
| padding: 1rem; | ||
| margin-bottom: 2rem; | ||
| background: #ffffff; | ||
| background: $color-background; |
Comment on lines
3
to
+15
| .folder-activity-flow { | ||
| // Chart color palette for contributors | ||
| --chart-color-1: #e06091; // githru-pri | ||
| --chart-color-2: #8840bb; // githru-sec | ||
| --chart-color-3: #ffd08a; // githru-ter | ||
| --chart-color-4: #07bebe; // githru-suc | ||
| --chart-color-5: #456cf7; // hacker-pri | ||
| --chart-color-6: #0687a3; // aqua-sec | ||
| --chart-color-7: #ffcccb; // cotton-pri | ||
| --chart-color-8: #feffd1; // cotton-sec | ||
| --chart-color-9: #3a4776; // mono-sec | ||
| --chart-color-10: #aa4b72; // mono-fai | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
#941
Result
스토리 라인 차트 디자인 수정했습니다!
Work list
Screen Shot
2025-10-08.1.28.41.mov
Discussion