feat(view): 스토리라인 차트 표시 버튼에 MUI 적용#951
Merged
Merged
Conversation
ytaek
previously approved these changes
Oct 8, 2025
ytaek
left a comment
ytaek
left a comment
Contributor
There was a problem hiding this comment.
앗.. 다른 PR에 바꾸면 좋겠다고 적었는데 바로 올라와있었군요!!!
LGTM입니다!!!
개인적으로는, storyline viz 를 의미하는 아이콘에다가
옆에 new 딱지 같은걸 붙여보면 좋을 것 같다는 생각도 해봅니다 : )
일단은 푸르딩딩한 못생긴 버튼이 안 보여서 넘 좋네요!!
hyemimi
previously approved these changes
Oct 9, 2025
hyemimi
left a comment
hyemimi
left a comment
Contributor
There was a problem hiding this comment.
아이콘 귀엽네요 ㅎㅎ 아이콘 옆에 NEW로 텍스트 보여지는 것도 좋은 아이디어인 것 같아요! 아이콘보다는 글씨가 살짝 작아도 좋을 것 같긴 합니다!
oortmealy
previously approved these changes
Oct 9, 2025
oortmealy
left a comment
oortmealy
left a comment
Member
There was a problem hiding this comment.
고생하셨습니다!! 아이콘과 new 텍스트가 함께있으니 의미가 잘 드러나는 것 같습니다 👍👍
lee-kyu-hwan
previously approved these changes
Oct 9, 2025
Jxxunnn
dismissed stale reviews from lee-kyu-hwan, oortmealy, and hyemimi
via
October 9, 2025 09:13
09c5ee4
…into feat/new-feature-entry-point
Contributor
Author
|
병합 충돌이 발생해서 해결하고 re-request review 드립니다 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
closes #907
Result
Work list
Discussion
MUI 컴포넌트 적용 및 멘토님 피드백 바탕으로 추가 개선했습니다.