[refactor](view): 스토리라인 차트 브래드크럼 MUI 컴포넌트로 변경#976
Merged
Conversation
hyemimi
approved these changes
Oct 11, 2025
Comment on lines
-62
to
-63
| display: flex; | ||
| align-items: center; |
Contributor
There was a problem hiding this comment.
'>' 아이콘이랑 텍스트가 세로 정렬이 안 되어있는데 아마 요 부분 삭제되어서 그런게 아닐까 추측해봅니당
Member
Author
There was a problem hiding this comment.
오 넵! 다음 pr에서 다시 수정해볼게요
| /** | ||
| * Navigate up to parent folder | ||
| */ | ||
| const navigateUp = useCallback(() => { |
Contributor
There was a problem hiding this comment.
(궁금) 오!! 요 함수 없어도 폴더 거슬러 올라갈 수 있나요?!
Member
Author
There was a problem hiding this comment.
넵! up버튼에서만 쓰이던 함수이고, 기존에도 브레드크럼의 폴더명 클릭하면 거슬러 올라갈 수 있었어요!
Comment on lines
+57
to
+59
| // 실제로 노드(activity)가 있는 폴더만 필터링 | ||
| const activeFolderPaths = Array.from(new Set(releaseContributorActivities.map((a) => a.folderPath))); | ||
| const filteredFolderPaths = releaseTopFolderPaths.filter((path) => activeFolderPaths.includes(path)); |
Contributor
There was a problem hiding this comment.
(궁금) 그러면 같은 폴더 내 activity가 없는 폴더(or 파일)들은 안 보여지게 되나요?
Member
Author
There was a problem hiding this comment.
네네! 기여자 노드가 없는 파일이 보여지는게 불필요한 것 같아서 제거했습니다
비포 애프터를 찍을걸 그랬네요🥲
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
#956 , #947
Result
Work list
Discussion