[new feature](view): StoryLine chart 타이틀/서브타이틀 구현#980
Merged
Conversation
oortmealy
changed the title
hyemimi
approved these changes
Oct 11, 2025
hyemimi
left a comment
hyemimi
left a comment
Contributor
There was a problem hiding this comment.
수고하셨습니당!!! ㅎㅎ 리뷰 내용은 중요한 건 아니구 그냥 확인만 해주시면 좋을 것 같아요ㅎㅎ
|
|
||
| const breadcrumbs = useMemo(() => getBreadcrumbs(), [getBreadcrumbs]); | ||
|
|
||
| const { topContributorName, releaseRangeLabel } = useMemo(() => { |
Contributor
There was a problem hiding this comment.
요 부분은 따로 유틸 파일로 빼서 모듈화해도 좋을 것 같아요! 이건 제가 추후에 작업해보겠습니다 ...!
Comment on lines
+150
to
+151
| const topContributorLabel = topContributorName || "..."; | ||
|
|
Contributor
There was a problem hiding this comment.
중요한 건 아니지만 데이터가 없을 때 ". . ."으로 적절한지 고민해볼 필요가 있겠네요 !!
Member
Author
There was a problem hiding this comment.
앗 맞아요!! 어떻게 하는게 좋을지...
일단 이대로 머지 하겠습니당!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
#959
Result
Work list
Discussion