Merge core/csmDict into main#992
Merged
Merged
Conversation
This reverts commit 40e7d30.
[FEAT] CSMDict 최신 → 과거 순서 정렬
This reverts commit 0bfab10.
- Add mergedIntoStem flag to track merge parents - Limit squash range to next merge point to prevent over-squashing - Fix commit sorting order (oldest to newest) - Update test cases with proper mergedIntoStem flags - Translate Korean comments to English in CommitNode.ts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Extract utility functions from buildCSMNode into csm.util.ts - getMergeParentCommit: Get merge parent commit - findSquashStartNodeIndex: Find node index in stem - findSquashEndIndex: Find end index for squash collection - collectSquashNodes: Collect nodes and remove from stem - extractNestedMergeParents: Extract nested merge parents - Create csm.const.ts for magic number constants - MERGE_PARENT_INDEX: Merge parent index - FIRST_PARENT_INDEX: First parent index - Refactor buildCSMNode function - Reduce function length from 72 lines to ~50 lines - Remove non-null assertions (! operator) - Improve type safety with optional chaining - Add clear comments for each step - Add comprehensive JSDoc documentation - Document all public and private functions - Add parameter and return type descriptions
- Add buildPaginatedCSMDict function with cursor-based pagination - Support perPage parameter to control page size - Implement lastCommitId cursor for next page navigation - Add comprehensive test coverage (8 test cases) - Extract buildPRDict utility function to reduce duplication - Export buildPaginatedCSMDict from package entry point The new function enables efficient lazy loading of CSM nodes for large repositories, improving performance and memory usage. Related: #916 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Extract buildCSMNodesWithPR to eliminate code duplication - Add comprehensive JSDoc documentation with examples - Improve validation consistency across functions - Enhance variable naming (prDict, baseStem) - Add stemDict.size validation to buildPaginatedCSMDict This refactoring improves maintainability and reusability while preserving all external behavior. All tests pass. Related: #916 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Consolidate MERGE_PARENT_INDEX and FIRST_PARENT_INDEX into a single FIRST_PARENT_INDEX constant, and rename getMergeParentCommit to getFirstParentCommit to improve code consistency and clarity. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…port - Add octopus merge test (4 parents) - Add single parent commit early return tests - Add non-existent parent commits edge case test - Add all invalid parents edge case test All 9 tests passing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…clarity 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
feat(engine): CSM Squash Merge 로직 개선
refactor(engine): CSM 코드 구조 및 가독성 개선
…ation feat(engine): Pagination 기능을 가진 CSM Dictionary Builder 구현
- Updates the 'fetchClusterNodes' function to consume the new paginated API from the engine.
- Updates interface to handle pagination requests and the new data structure.
feat: csm pagination api
feat : csm pagination view
nxnaxx
approved these changes
Oct 15, 2025
nxnaxx
left a comment
nxnaxx
left a comment
Contributor
There was a problem hiding this comment.
와아 두 분 다 정말 수고 많으셨습니다!!👍🏻👍🏻👍🏻
Contributor
|
드뎌 메인 브랜치로!! 환영합니다!! |
ytaek
approved these changes
Oct 15, 2025
ytaek
left a comment
ytaek
left a comment
Contributor
There was a problem hiding this comment.
아.. linting된 파일이 많았네요;; 머지하기 좀 무섭긴 합니다만 일단 LGTM 입니다!!
고생하셨어요!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ready for CSM Pagination!! 🎉🎉
react 레포지토리에서 테스트 결과 FCP 를 약 60% 단축할 수 있었습니다! (58.740s → 23.148s) <Issue #991>
2025-10-15.3.35.50.mov