-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add support for Lambdapi language (.lp) #7549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
The samples/Lambdapi/List.lp sample is also too big. If it's suppressed in the diff, it's too big for our needs. Please replace it.
Can you please update the search query in the PR template to more accurately identify just this langauge. From a quick look it appears to be matching other languages already correctly identified. You can use regular expressions so I'd recommend using the one you're adding for the heuristic, once you've addressed the problems with it.
I believe all the comments have been addressed. Please let me know if any more changes are required. |
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
|
Hi @lildude, Are there any more changes requested to merge this PR? |
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your heuristic is vulnerable to ReDoS. We require all regular expressions to be linear, safe from ReDoS and RE2 compatible. Please fix this.
Once fixed, this PR won't be merged until our popularity requirement is met. This is checked when a new release is made and I do not comment if the usage still hasn't been met.
Description
Checklist:
#8027a3