Conversation
|
Oh, I just noticed I made a mistake in the last two commit messages, instead of |
lildude
left a comment
There was a problem hiding this comment.
Your Unity3D samples are way too big. If they're suppressed in the diff, they're too big. Please replace them with smaller samples.
Popularity doesn't appear to meet our requirements yet either.
|
Done! The samples have been simplified and are now visible in the diff. |
No. See #5756 which is referenced in the CONTRIBUTING.md file too. |
Indeed, unlike other assets associated to that language, the nature of |
|
Another desired implication would be that these files will be treated the equally as other Unity assets, meaning they will not be included on the statistics for each repo. Since these layout files are generated using the editor the user never really gets any inference over the contents on a text editor environment, resulting in this big file is undesirably indexed, and requiring a workarounds as mentioned here |
🤔 A quick search shows it's quite common for repos to have more than one of these files, hence my previous comment. |
Description
As described in this response on an existing issue (#5862), the
.wltfiles present in Unity projects get misclassified asMathematica. Of the 1.9k.wltfiles found on GitHub, 1.2k (i.e. 63.15%) appear to be misclassified due to this file extension not being included in theUnity3D Assetlanguage.In this PR I'm adding the
.wltextension to theUnity3D Assetlanguage, creating the (two) corresponding samples and including a second sample for theMathematicalanguage.Checklist:
[ x ] I am adding a new extension to a language.
Note
A third usage for this file extension seems to be around, but it does not yet meet the 200-unique-user/repo requirement in order to be implemented, See usage.