Identify *.MODULE.bazel files as Starlark#7624
Open
rafikk wants to merge 1 commit intogithub-linguist:mainfrom
Open
Identify *.MODULE.bazel files as Starlark#7624rafikk wants to merge 1 commit intogithub-linguist:mainfrom
rafikk wants to merge 1 commit intogithub-linguist:mainfrom
Conversation
f984746 to
3e2c293
Compare
Author
|
Hi @lildude. Thanks for taking a look and unblocking the CI checks. I believe with the latest set of changes, the checks should be passing now. I see you've added the "Pending Popularity" label to this PR. What is the threshold for getting this change merged? The checklist say "hundreds of repositories" and search shows 175 public files (though I'm not sure in how many unique repositories). I assumed that >100 repositories would qualify. Is there a more specific threshold? |
3e2c293 to
bc63ccc
Compare
Member
Lines 79 to 80 in 347e912 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel 7.2.0 introduced the ability to include the contents of another "MODULE.bazel-like" file in MODULE.bazel. These files must be suffixed with ".MODULE.bazel" and should be identified as Starlark, just like the root MODULE.bazel file.
Checklist: