Skip to content

Conversation

@rafikk
Copy link

@rafikk rafikk commented Oct 2, 2025

Bazel 7.2.0 introduced the ability to include the contents of another "MODULE.bazel-like" file in MODULE.bazel. These files must be suffixed with ".MODULE.bazel" and should be identified as Starlark, just like the root MODULE.bazel file.

Checklist:

@rafikk rafikk requested a review from a team as a code owner October 2, 2025 09:53
@rafikk rafikk force-pushed the starlark-module-bazel branch 2 times, most recently from f984746 to 3e2c293 Compare October 6, 2025 11:17
@rafikk
Copy link
Author

rafikk commented Oct 6, 2025

Hi @lildude. Thanks for taking a look and unblocking the CI checks. I believe with the latest set of changes, the checks should be passing now.

I see you've added the "Pending Popularity" label to this PR. What is the threshold for getting this change merged? The checklist say "hundreds of repositories" and search shows 175 public files (though I'm not sure in how many unique repositories). I assumed that >100 repositories would qualify. Is there a more specific threshold?

@rafikk rafikk force-pushed the starlark-module-bazel branch from 3e2c293 to bc63ccc Compare October 6, 2025 11:52
@lildude
Copy link
Member

lildude commented Oct 6, 2025

I assumed that >100 repositories would qualify. Is there a more specific threshold?

linguist/CONTRIBUTING.md

Lines 79 to 80 in 347e912

In most cases we prefer that each new file extension be in use in at least 200 unique `:user/:repo` repositories before supporting them in Linguist
(but see [#5756][] for a temporary change in the criteria).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants