-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Identify .pubxml as XML
#7636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Identify .pubxml as XML
#7636
Conversation
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have included a real-world usage sample for all extensions added in this PR:
* Sample source(s): * https://github.com/ultraslayyy/I-am-bored/blob/info/notepad%23/src/Properties/PublishProfiles/Win64.pubxml (I couldn't find an official Microsoft file on GitHub for this, so I used my own)
You need to add it to the relevant samples directory in this repo.
Any example with an open source license will do.
|
Ok I have done that :) |
|
A link to your fork of this repo is not the original source. Please update this link to the original source of the sample and state the license (you've deleted the license point from the template). |
|
I think I fixed it. I'm sorry if I haven't, my brain just isn't at 100% rn :) |
|
Ooops. I forgot the XML strategy test needs modification too. You can fix the failing test by adding the sample path to the array in the test: linguist/test/test_strategies.rb Lines 176 to 195 in 2409807
|
Description
Checklist: