Skip to content

Conversation

@ultraslayyy
Copy link

@ultraslayyy ultraslayyy commented Oct 16, 2025

Description

Checklist:

@ultraslayyy ultraslayyy marked this pull request as ready for review October 16, 2025 09:41
@ultraslayyy ultraslayyy requested a review from a team as a code owner October 16, 2025 09:41
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included a real-world usage sample for all extensions added in this PR:

* Sample source(s):
  
  * https://github.com/ultraslayyy/I-am-bored/blob/info/notepad%23/src/Properties/PublishProfiles/Win64.pubxml (I couldn't find an official Microsoft file on GitHub for this, so I used my own)

You need to add it to the relevant samples directory in this repo.

Any example with an open source license will do.

@ultraslayyy
Copy link
Author

Ok I have done that :)

@ultraslayyy ultraslayyy requested a review from lildude October 17, 2025 07:28
@lildude
Copy link
Member

lildude commented Oct 17, 2025

A link to your fork of this repo is not the original source. Please update this link to the original source of the sample and state the license (you've deleted the license point from the template).

@ultraslayyy
Copy link
Author

I think I fixed it. I'm sorry if I haven't, my brain just isn't at 100% rn :)

@lildude
Copy link
Member

lildude commented Oct 17, 2025

Ooops. I forgot the XML strategy test needs modification too.

You can fix the failing test by adding the sample path to the array in the test:

def test_xml
no_root_tag = [
"#{samples_path}/XML/libsomething.dll.config",
"#{samples_path}/XML/real-estate.mjml",
"#{samples_path}/XML/XmlIO.pluginspec",
"#{samples_path}/XML/MainView.ux",
"#{samples_path}/XML/MyApp.ux",
"#{samples_path}/XML/xhtml-struct-1.mod",
"#{samples_path}/XML/wixdemo.wixproj",
"#{samples_path}/XML/msbuild-example.proj",
"#{samples_path}/XML/sample.targets",
"#{samples_path}/XML/Default.props",
"#{samples_path}/XML/racoon.mjml",
"#{samples_path}/XML/route-gas-works-lake-union-loop.gpx",
"#{samples_path}/XML/some-ideas.mm",
"#{samples_path}/XML/GMOculus.project.gmx",
"#{samples_path}/XML/obj_control.object.gmx",
"#{samples_path}/XML/MainView.axaml",
"#{samples_path}/XML/Robots.slnx",
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants