Skip to content

Conversation

@fabn
Copy link
Contributor

@fabn fabn commented Nov 22, 2024

I need to pass some parameters to my deployment and I initially thought to write a simple action to parse parameters returned by this action. However the parser I chose and works out of the box with strings inputs returning a sensible set of defaults, so I sketched a simple params parser and integrated it into this action.

Let me know if you're interested in this so I can continue to develop this.

@fabn fabn requested a review from GrantBirki as a code owner November 22, 2024 16:48
@fabn fabn changed the title Add parsedParams output Add parsed_params output Nov 22, 2024
@GrantBirki
Copy link
Contributor

@fabn thank you for this! I can see a lot of value in having the parser / output controlled directly from this Action rather than having it be elsewhere. I will take some time to review and get these changed merged in for you. Thanks!

@GrantBirki GrantBirki added the enhancement New feature or request label Nov 22, 2024
@GrantBirki GrantBirki self-assigned this Nov 22, 2024
@GrantBirki GrantBirki merged commit 8e57417 into github:main Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants