Skip to content

Allow configuring CODEQL_THREADS with an env var #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

austinpray-mixpanel
Copy link

closes #2890

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@Copilot Copilot AI review requested due to automatic review settings May 6, 2025 02:29
@austinpray-mixpanel austinpray-mixpanel requested a review from a team as a code owner May 6, 2025 02:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables configuring the number of CodeQL threads via an environment variable.

  • Allows users to override the thread count using CODEQL_THREADS in the environment.
  • Falls back to computing the thread value based on the "threads" input if the env var is not set.

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I don't think this is harmful or could break anything, but it seems a bit redundant.

Can you try this alternate approach?

In the init/actions.yml file add default: "${{ env.CODEQL_THREADS }}" to the threads input. This should be sufficient.

@austinpray-mixpanel
Copy link
Author

Thanks for your PR. I don't think this is harmful or could break anything, but it seems a bit redundant.

Can you try this alternate approach?

In the init/actions.yml file add default: "${{ env.CODEQL_THREADS }}" to the threads input. This should be sufficient.

Yep I can give this a shot. My initial change was just trying to match up the way the ram variable was treated

@aeisenberg
Copy link
Contributor

Yep I can give this a shot. My initial change was just trying to match up the way the ram variable was treated

Great. Let me know if this works for you. Now that I'm engaged, I'll be able to respond more quickly to this PR.

@austinpray-mixpanel
Copy link
Author

@aeisenberg lmk what you think 👍

aeisenberg
aeisenberg previously approved these changes May 13, 2025
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me.

@austinpray-mixpanel
Copy link
Author

@aeisenberg ah I don't think you can use env variable expressions in inputs

Error: /Users/runner/work/codeql-action/codeql-action/./../action/init/action.yml (Line: 118, Col: 14): Unrecognized named-value: 'env'. Located at position 1 within expression: env.CODEQL_THREADS

@aeisenberg
Copy link
Contributor

Oh...that's really unfortunate. Apologies for the confusion. I'm asking internally what's going on since this is a pattern that's being used elsewhere.

@aeisenberg aeisenberg added Rebuild Re-transpile JS & re-generate workflows and removed Rebuild Re-transpile JS & re-generate workflows labels May 14, 2025
@aibaars
Copy link
Collaborator

aibaars commented May 14, 2025

Oh...that's really unfortunate. Apologies for the confusion. I'm asking internally what's going on since this is a pattern that's being used elsewhere.

Most of those examples commented out the default field with a # though. I'm not sure why the env context is not allowed, perhaps it is not available until a workflow starts to "run".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rebuild Re-transpile JS & re-generate workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to configure CODEQL_THREADS with an environment variable
3 participants