-
Notifications
You must be signed in to change notification settings - Fork 356
Allow configuring CODEQL_THREADS with an env var #2891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables configuring the number of CodeQL threads via an environment variable.
- Allows users to override the thread count using CODEQL_THREADS in the environment.
- Falls back to computing the thread value based on the "threads" input if the env var is not set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I don't think this is harmful or could break anything, but it seems a bit redundant.
Can you try this alternate approach?
In the init/actions.yml
file add default: "${{ env.CODEQL_THREADS }}"
to the threads
input. This should be sufficient.
Yep I can give this a shot. My initial change was just trying to match up the way the ram variable was treated |
Great. Let me know if this works for you. Now that I'm engaged, I'll be able to respond more quickly to this PR. |
@aeisenberg lmk what you think 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me.
@aeisenberg ah I don't think you can use env variable expressions in inputs
|
This reverts commit df7d681.
Oh...that's really unfortunate. Apologies for the confusion. I'm asking internally what's going on since this is a pattern that's being used elsewhere. |
Most of those examples commented out the |
closes #2890
Merge / deployment checklist