Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add new Apache CXF generated models #14030

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atorralba
Copy link
Contributor

Added generated summaries and neutrals for Apache CXF. No change note required since this is meant to go in conjunction with #14029.

@atorralba atorralba added the no-change-note-required This PR does not need a change note label Aug 23, 2023
@atorralba atorralba requested a review from a team as a code owner August 23, 2023 08:51
@github-actions github-actions bot added the Java label Aug 23, 2023
@github-actions
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Others,"``actions.osgi``, ``antlr``, ``cn.hutool.core.codec``, ``com.alibaba.druid.sql``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.google.gson``, ``com.hubspot.jinjava``, ``com.jcraft.jsch``, ``com.mitchellbosecke.pebble``, ``com.opensymphony.xwork2``, ``com.rabbitmq.client``, ``com.thoughtworks.xstream``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``freemarker.cache``, ``freemarker.template``, ``groovy.lang``, ``groovy.text``, ``groovy.util``, ``hudson``, ``io.jsonwebtoken``, ``io.netty.bootstrap``, ``io.netty.buffer``, ``io.netty.channel``, ``io.netty.handler.codec``, ``io.netty.handler.ssl``, ``io.netty.handler.stream``, ``io.netty.resolver``, ``io.netty.util``, ``javafx.scene.web``, ``jenkins``, ``jodd.json``, ``net.sf.json``, ``net.sf.saxon.s9api``, ``ognl``, ``okhttp3``, ``org.acegisecurity``, ``org.antlr.runtime``, ``org.apache.commons.codec``, ``org.apache.commons.compress.archivers.tar``, ``org.apache.commons.exec``, ``org.apache.commons.httpclient.util``, ``org.apache.commons.jelly``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.lang``, ``org.apache.commons.logging``, ``org.apache.commons.net``, ``org.apache.commons.ognl``, ``org.apache.directory.ldap.client.api``, ``org.apache.hadoop.fs``, ``org.apache.hadoop.hive.metastore``, ``org.apache.hc.client5.http.async.methods``, ``org.apache.hc.client5.http.classic.methods``, ``org.apache.hc.client5.http.fluent``, ``org.apache.hive.hcatalog.templeton``, ``org.apache.ibatis.jdbc``, ``org.apache.log4j``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.apache.struts.beanvalidation.validation.interceptor``, ``org.apache.struts2``, ``org.apache.tools.ant``, ``org.apache.tools.zip``, ``org.apache.velocity.app``, ``org.apache.velocity.runtime``, ``org.codehaus.cargo.container.installer``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.eclipse.jetty.client``, ``org.fusesource.leveldbjni``, ``org.geogebra.web.full.main``, ``org.gradle.api.file``, ``org.hibernate``, ``org.influxdb``, ``org.jdbi.v3.core``, ``org.jenkins.ui.icon``, ``org.jenkins.ui.symbol``, ``org.jooq``, ``org.kohsuke.stapler``, ``org.mvel2``, ``org.openjdk.jmh.runner.options``, ``org.owasp.esapi``, ``org.scijava.log``, ``org.slf4j``, ``org.thymeleaf``, ``org.xml.sax``, ``org.xmlpull.v1``, ``org.yaml.snakeyaml``, ``play.libs.ws``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``, ``retrofit2``",126,10084,656,89,6,18,18,,200
+    Others,"``actions.osgi``, ``antlr``, ``cn.hutool.core.codec``, ``com.alibaba.druid.sql``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.google.gson``, ``com.hubspot.jinjava``, ``com.jcraft.jsch``, ``com.mitchellbosecke.pebble``, ``com.opensymphony.xwork2``, ``com.rabbitmq.client``, ``com.thoughtworks.xstream``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``freemarker.cache``, ``freemarker.template``, ``groovy.lang``, ``groovy.text``, ``groovy.util``, ``hudson``, ``io.jsonwebtoken``, ``io.netty.bootstrap``, ``io.netty.buffer``, ``io.netty.channel``, ``io.netty.handler.codec``, ``io.netty.handler.ssl``, ``io.netty.handler.stream``, ``io.netty.resolver``, ``io.netty.util``, ``javafx.scene.web``, ``jenkins``, ``jodd.json``, ``net.sf.json``, ``net.sf.saxon.s9api``, ``ognl``, ``okhttp3``, ``org.acegisecurity``, ``org.antlr.runtime``, ``org.apache.commons.codec``, ``org.apache.commons.compress.archivers.tar``, ``org.apache.commons.exec``, ``org.apache.commons.httpclient.util``, ``org.apache.commons.jelly``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.lang``, ``org.apache.commons.logging``, ``org.apache.commons.net``, ``org.apache.commons.ognl``, ``org.apache.cxf``, ``org.apache.directory.ldap.client.api``, ``org.apache.hadoop.fs``, ``org.apache.hadoop.hive.metastore``, ``org.apache.handler_test``, ``org.apache.handlers``, ``org.apache.hc.client5.http.async.methods``, ``org.apache.hc.client5.http.classic.methods``, ``org.apache.hc.client5.http.fluent``, ``org.apache.header_test``, ``org.apache.headers``, ``org.apache.hello_world``, ``org.apache.hello_world_doc_lit``, ``org.apache.hello_world_doc_lit_bare.types``, ``org.apache.hello_world_mixedstyle``, ``org.apache.hello_world_rpclit``, ``org.apache.hello_world_soap12_http``, ``org.apache.hello_world_soap_action.types.wrapped``, ``org.apache.hello_world_soap_http``, ``org.apache.hello_world_soap_http_secure.types``, ``org.apache.hello_world_soap_http_underscore.types``, ``org.apache.hello_world_xml_http.bare``, ``org.apache.hello_world_xml_http.mixed``, ``org.apache.hello_world_xml_http.wrapped``, ``org.apache.hive.hcatalog.templeton``, ``org.apache.ibatis.jdbc``, ``org.apache.intfault``, ``org.apache.locator``, ``org.apache.log4j``, ``org.apache.nested_callback``, ``org.apache.samples.headers``, ``org.apache.schema_validation``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.apache.struts.beanvalidation.validation.interceptor``, ``org.apache.struts2``, ``org.apache.tests.type_test.all``, ``org.apache.tests.type_test.choice``, ``org.apache.tests.type_test.sequence``, ``org.apache.tools.ant``, ``org.apache.tools.zip``, ``org.apache.type_substitution``, ``org.apache.type_test.doc``, ``org.apache.type_test.types1``, ``org.apache.type_test.types2``, ``org.apache.type_test.types3``, ``org.apache.type_test.xml``, ``org.apache.velocity.app``, ``org.apache.velocity.runtime``, ``org.codehaus.cargo.container.installer``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.eclipse.jetty.client``, ``org.example.contract.doubleit``, ``org.example.schema.doubleit``, ``org.fusesource.leveldbjni``, ``org.geogebra.web.full.main``, ``org.gradle.api.file``, ``org.hibernate``, ``org.influxdb``, ``org.jdbi.v3.core``, ``org.jenkins.ui.icon``, ``org.jenkins.ui.symbol``, ``org.jooq``, ``org.kohsuke.stapler``, ``org.mvel2``, ``org.oasis_open.docs.wsn.b_2``, ``org.oasis_open.docs.wsn.br_2``, ``org.oasis_open.docs.wsn.brw_2``, ``org.oasis_open.docs.wsn.bw_2``, ``org.oasis_open.docs.wsn.t_1``, ``org.oasis_open.docs.wsrf.bf_2``, ``org.oasis_open.docs.wsrf.rp_2``, ``org.oasis_open.docs.wsrf.rpw_2``, ``org.oasis_open.docs.wsrf.rw_2``, ``org.openjdk.jmh.runner.options``, ``org.owasp.esapi``, ``org.scijava.log``, ``org.slf4j``, ``org.thymeleaf``, ``org.w3._2002._03.xkms_wsdl``, ``org.xml.sax``, ``org.xmlpull.v1``, ``org.xmlsoap.ping``, ``org.yaml.snakeyaml``, ``play.libs.ws``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``, ``retrofit2``, ``uri.cxf_apache_org.jstest``, ``wssec.wssc``, ``wssec.wssec10``, ``wssec.wssec11``",126,27959,656,89,6,18,18,,200
-    Totals,,283,18456,2144,286,16,122,33,1,391
+    Totals,,283,36331,2144,286,16,122,33,1,391
  • Changes to framework-coverage-java.csv:
+ org.apache.cxf,,,13624,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,13546,78
+ org.apache.handler_test,,,14,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,14,
+ org.apache.handlers,,,13,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,13,
+ org.apache.header_test,,,37,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,37,
+ org.apache.headers,,,56,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,56,
+ org.apache.hello_world,,,16,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,16,
+ org.apache.hello_world_doc_lit,,,18,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,18,
+ org.apache.hello_world_doc_lit_bare.types,,,2,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,2,
+ org.apache.hello_world_mixedstyle,,,21,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,21,
+ org.apache.hello_world_rpclit,,,8,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,8,
+ org.apache.hello_world_soap12_http,,,11,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,11,
+ org.apache.hello_world_soap_action.types.wrapped,,,8,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,8,
+ org.apache.hello_world_soap_http,,,73,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,73,
+ org.apache.hello_world_soap_http_secure.types,,,12,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,12,
+ org.apache.hello_world_soap_http_underscore.types,,,4,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,4,
+ org.apache.hello_world_xml_http.bare,,,7,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,7,
+ org.apache.hello_world_xml_http.mixed,,,18,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,18,
+ org.apache.hello_world_xml_http.wrapped,,,18,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,18,
+ org.apache.intfault,,,10,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,10,
+ org.apache.locator,,,55,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,55,
+ org.apache.nested_callback,,,4,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,4,
+ org.apache.samples.headers,,,16,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,16,
+ org.apache.schema_validation,,,38,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,38,
+ org.apache.tests.type_test.all,,,4,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,4,
+ org.apache.tests.type_test.choice,,,2,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,2,
+ org.apache.tests.type_test.sequence,,,4,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,4,
+ org.apache.type_substitution,,,11,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,11,
+ org.apache.type_test.doc,,,1469,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,1469,
+ org.apache.type_test.types1,,,151,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,151,
+ org.apache.type_test.types2,,,93,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,93,
+ org.apache.type_test.types3,,,60,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,60,
+ org.apache.type_test.xml,,,1469,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,1469,
+ org.example.contract.doubleit,,,9,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,9,
+ org.example.schema.doubleit,,,2,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,2,
+ org.oasis_open.docs.wsn.b_2,,,94,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,94,
+ org.oasis_open.docs.wsn.br_2,,,23,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,23,
+ org.oasis_open.docs.wsn.brw_2,,,27,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,27,
+ org.oasis_open.docs.wsn.bw_2,,,181,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,181,
+ org.oasis_open.docs.wsn.t_1,,,23,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,23,
+ org.oasis_open.docs.wsrf.bf_2,,,21,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,21,
+ org.oasis_open.docs.wsrf.rp_2,,,53,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,53,
+ org.oasis_open.docs.wsrf.rpw_2,,,9,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,9,
+ org.oasis_open.docs.wsrf.rw_2,,,18,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,18,
+ org.w3._2002._03.xkms_wsdl,,,9,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,9,
+ org.xmlsoap.ping,,,12,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,12,
+ uri.cxf_apache_org.jstest,,,36,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,36,
+ wssec.wssc,,,4,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,4,
+ wssec.wssec10,,,4,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,4,
+ wssec.wssec11,,,4,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,4,

@atorralba
Copy link
Contributor Author

DCA is uneventful.

Copy link
Contributor

@jcogs33 jcogs33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m surprised that there are no new alerts on DCA for 17000+ new summary models (that’s roughly double the number of models for JDK 😲). Would it be worthwhile to rerun DCA with a source-suite that is more specific to Apache CXF?

Also, there seem to be several neutral models that conflict with summaries similar to what I noticed previously, a few summary models that are duplicated as both taint and value, and some packages that look like they don't belong to Apache CXF (e.g. org.springframework.beans.factory.wiring). I'm not sure if these issues should prevent merging. 🤷

@atorralba
Copy link
Contributor Author

Hm, good catches, thanks @jcogs33. I think I was being too optimistic blindly trusting the generator when we're consistently getting these sort of errors. This PR isn't urgent by any means, so I'll make this a draft and take a note about investigating all this before merging any generated models.

@atorralba atorralba marked this pull request as draft September 29, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants