C++: Fix more FPs in cpp/invalid-pointer-deref
#14164
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/analysis/Bound.qll
Fixed
Show resolved
Hide resolved
MathiasVP
force-pushed
the
fix-more-fps-in-invalid-pointer-deref
branch
from
cc65e15 to
4bab9a1
Compare
MathiasVP
commented
Sep 7, 2023
MathiasVP
force-pushed
the
fix-more-fps-in-invalid-pointer-deref
branch
4 times, most recently
from
6fd42ca to
45b220f
Compare
MathiasVP
force-pushed
the
fix-more-fps-in-invalid-pointer-deref
branch
from
45b220f to
e6acf31
Compare
MathiasVP
force-pushed
the
fix-more-fps-in-invalid-pointer-deref
branch
from
e6acf31 to
7532591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by some FPs that
@turbowas observing on MRVA. We had reduced testcases for some of his examples already, so I decided to solve those first.