JS: Expose whether an endpoint name is synthetic #15975
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EndpointNaming
library was written to support two use-cases: the model editor, and VEA.However, I think they differ in how they should deal with the "semi-internal class" problem:
For the model editor use-case, it seemed best to synthesise a name for
InternalClass.m()
above, rather than give up entirely.This is not ideal for the other use-case however, so this change exposes a
boolean
parameter to know whether the name is synthetic or not.