JS: Support value access paths in MaD type columns #16037
Draft
+139
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+150
to
+152
| [ | ||
| "(global).fqnSource;;test-source", // | ||
| ] |
Check warning
Code scanning / CodeQL
Singleton set literal Warning test
|
Taking back into draft as I'm starting to have second thoughts about this approach. The problem is that the logic in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
typestring of form(package).accessPathis now interpreted as value access path, that is, an access path interpreted as a value rather than a type. This is useful to have whenever we generate models from source code, as opposed to from.d.tsfiles.The syntax is chosen to coincide with the FQN format, see backlink.