Rust extractors: Normalize drive letter paths with a trailing /
#18770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
shared/windows-drive-letter-trap-id
branch
from
a3c077c to
02fd23e
Compare
hvitved
changed the title
//
There was a problem hiding this comment.
PR Overview
This PR updates the path normalization function to ensure that drive letter paths ending at the root include a trailing slash (e.g., "C:/" instead of "C:").
- Replaces the simple for loop with a peekable iterator to check if the current component is the final one.
- Adds logic to push an empty string for the RootDir component when it is the last component, thereby achieving the desired trailing slash.
Changes
| File | Description |
|---|---|
| shared/tree-sitter-extractor/src/file_paths.rs | Updated path normalization to add a trailing slash for root drive paths |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
shared/tree-sitter-extractor/src/file_paths.rs:30
- Consider adding tests to verify that normalizing a drive letter root path correctly returns a trailing slash.
std::path::Component::RootDir => {
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
aibaars
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #18767 I learned that root paths on Windows, like
c:\, are currently normalized toC:, while the shared YAML extractor normalizes it asC:/. This PR aligns the behavior of the Rust-based extractors with the YAML extractor.