Rust/Swift: Cache Element.toString
#18968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| module Impl { | |||
| class Decl extends Generated::Decl { | |||
| override string toString() { result = super.toString() } | |||
| override string toStringImpl() { result = super.toStringImpl() } | |||
Check warning
Code scanning / CodeQL
Redundant override Warning
hvitved
force-pushed
the
rust/cache-to-string
branch
3 times, most recently
from
5ab442f to
03a87de
Compare
hvitved
changed the title
Element.toStringElement.toString
hvitved
force-pushed
the
rust/cache-to-string
branch
from
03a87de to
dcd01be
Compare
|
Rebased to resolve merge conflict. |
redsun82
approved these changes
Mar 17, 2025
|
Swift integration tests failure is a timeout flake, merging this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, we cannot put the
cachedannotation directly on the existingtoStringpredicate, as that introduces spurious non-monotonicity errors (the non-monotonicity checker considerscachedpredicates to be black-boxes). Instead, we add an intermediatetoStringImplpredicate, which acts like the previoustoStringpredicate, and then cache the newtoStringpredicate, which simply forwards totoStringImpl.DCA shows a nice average 7% analysis time speedup.