-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the CCR query suite to code-quality #18974
base: main
Are you sure you want to change the base?
Rename the CCR query suite to code-quality #18974
Conversation
We need to make sure that
|
Would also need to update the known packs in spark: |
f78e726
to
97adaa9
Compare
@rvermeulen Thank you. Done in 97adaa9. |
I don't know anything about this. It looks like we already have a "quality" suite there, should that be renamed? Can we rename entries here without breaking other tools/queries? Should we keep the CCR name? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames all references of the "CCR" query suite to "code-quality" to align file naming conventions.
- Update the "packs" list by replacing "ccr" with "code-quality".
- Update the warning message to reflect the new suite name "code-quality".
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to also rename the C++ suite: https://github.com/github/codeql/blob/main/cpp/ql/src/codeql-suites/cpp-ccr.qls
Changes made to misc/scripts/generate-code-scanning-query-list.py
LGTM, but do get a green run of the Build code scanning query list job before merging 👍
97adaa9
to
a021492
Compare
a021492
to
6cd49f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C# LGTM
Is there a PR for updating the corresponding DCA source suite?
This PR renames all
CCR.qls
files tocode-quality.qls
.