Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the CCR query suite to code-quality #18974

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Mar 11, 2025

This PR renames all CCR.qls files to code-quality.qls.

@github-actions github-actions bot added C# JS Java Python Go Ruby Rust Pull requests that update Rust code Swift Actions Analysis of GitHub Actions labels Mar 11, 2025
@rvermeulen
Copy link
Contributor

We need to make sure that

if pack == 'ccr' and queries_subp == '':
is also updated.

@jonjanego
Copy link
Member

@tamasvajk tamasvajk force-pushed the tamasvajk/rename-ccr-suite-quality branch from f78e726 to 97adaa9 Compare March 12, 2025 09:28
@tamasvajk
Copy link
Contributor Author

We need to make sure that

if pack == 'ccr' and queries_subp == '':

is also updated.

@rvermeulen Thank you. Done in 97adaa9.

@tamasvajk
Copy link
Contributor Author

Would also need to update the known packs in spark:

https://github.com/github/codeql-team/blob/9ca0db3a66078afc75234dd0ede416bd5feae646/tools/spark/src/lib/codeql.nim#L31

I don't know anything about this. It looks like we already have a "quality" suite there, should that be renamed? Can we rename entries here without breaking other tools/queries? Should we keep the CCR name?

@tamasvajk tamasvajk marked this pull request as ready for review March 12, 2025 09:33
@Copilot Copilot bot review requested due to automatic review settings March 12, 2025 09:33
@tamasvajk tamasvajk requested review from RasmusWL and a team as code owners March 12, 2025 09:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames all references of the "CCR" query suite to "code-quality" to align file naming conventions.

  • Update the "packs" list by replacing "ccr" with "code-quality".
  • Update the warning message to reflect the new suite name "code-quality".

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@tamasvajk tamasvajk requested a review from rvermeulen March 12, 2025 09:33
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also rename the C++ suite: https://github.com/github/codeql/blob/main/cpp/ql/src/codeql-suites/cpp-ccr.qls

Changes made to misc/scripts/generate-code-scanning-query-list.py LGTM, but do get a green run of the Build code scanning query list job before merging 👍

@tamasvajk tamasvajk force-pushed the tamasvajk/rename-ccr-suite-quality branch from 97adaa9 to a021492 Compare March 13, 2025 09:04
@tamasvajk tamasvajk requested a review from a team as a code owner March 13, 2025 09:04
@github-actions github-actions bot added the C++ label Mar 13, 2025
@tamasvajk tamasvajk force-pushed the tamasvajk/rename-ccr-suite-quality branch from a021492 to 6cd49f4 Compare March 14, 2025 09:21
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# LGTM
Is there a PR for updating the corresponding DCA source suite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions C# C++ Go Java JS Python Ruby Rust Pull requests that update Rust code Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants