Java: Eliminate pointless use of PathNodes over DataFlow::Node #20448
+16
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of PathNode prevents these from being overlay informed.
Contributor
|
This looks like a nice simplification that we simply want to merge. Reopening. |
aschackmull
approved these changes
Jan 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors four predicates within a parameterized module to use DataFlow::Node instead of PathNode for their source and sink parameters. This change enables these predicates to be overlay informed, making them more flexible for extension.
Changes:
- Simplified function signatures by replacing
GetInstanceToInitToUseFlow::PathNodeparameters withDataFlow::Node - Updated predicate calls from
flowPath()toflow()to match the new parameter types - Removed
.getNode()accessor calls since parameters are now directDataFlow::Nodeinstances
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of PathNode prevents these from being overlay informed.